From: johan@kernel.org (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function
Date: Thu, 20 Jul 2017 12:05:09 +0200 [thread overview]
Message-ID: <20170720100509.GB2729@localhost> (raw)
In-Reply-To: <47055927-5102-b39f-fdbb-b5d89cb14632@ti.com>
On Thu, Jul 20, 2017 at 03:32:27PM +0530, Keerthy wrote:
> On Thursday 20 July 2017 03:20 PM, Johan Hovold wrote:
> > On Thu, Jul 20, 2017 at 02:40:37PM +0530, Keerthy wrote:
> >> On Thursday 20 July 2017 12:14 PM, Keerthy wrote:
> >>> On Wednesday 19 July 2017 04:40 PM, Johan Hovold wrote:
> >>>> There's a separate but related bug here too as the clk_prepare_enable()
> >>>> in davinci_gpio_irq_setup() is never balanced on driver unbind.
> >>>
> >>> Yes Johan. I will send that as a separate patch.
> >>
> >> This is already fixed in the latest kernel:
> >>
> >> commit 6dc0048cff988858254fcc26becfc1e9753efa79
> >> Author: Arvind Yadav <arvind.yadav.cs@gmail.com>
> >> Date: Tue May 23 14:48:57 2017 +0530
> >
> > That change only handles errors in davinci_gpio_irq_setup() (i.e. during
> > probe) and not the imbalance at driver unbind that I was referring to.
>
> Okay got it. One more clk_unprepare_disable() call needs to be there in
> probe err path.
No, you need to balance it on driver unbind, that is, in a new remove()
callback.
Johan
next prev parent reply other threads:[~2017-07-20 10:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 10:57 [PATCH 0/4] gpio: davinci: Add keystone-k2g support and few clean ups Keerthy
2017-07-18 10:57 ` [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data Keerthy
2017-07-18 16:50 ` Suman Anna
2017-07-18 17:45 ` Keerthy
2017-07-19 9:37 ` Johan Hovold
2017-07-19 9:58 ` Keerthy
2017-07-18 10:57 ` [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Keerthy
2017-07-18 16:54 ` Suman Anna
2017-07-18 17:46 ` Keerthy
2017-07-19 11:10 ` Johan Hovold
2017-07-20 6:44 ` Keerthy
2017-07-20 9:10 ` Keerthy
2017-07-20 9:50 ` Johan Hovold
2017-07-20 10:02 ` Keerthy
2017-07-20 10:05 ` Johan Hovold [this message]
2017-07-20 10:10 ` Keerthy
2017-07-20 21:34 ` Grygorii Strashko
2017-07-21 3:53 ` Keerthy
2017-07-21 7:46 ` Johan Hovold
2017-07-18 10:57 ` [PATCH 3/4] gpio: davinci: Add a separate compatible for keystone-k2g soc Keerthy
2017-07-18 11:31 ` Sekhar Nori
2017-07-18 17:48 ` Keerthy
2017-07-24 18:24 ` Rob Herring
2017-07-25 3:22 ` Keerthy
2017-07-18 10:57 ` [PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy
2017-07-18 19:13 ` Suman Anna
2017-07-19 4:06 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720100509.GB2729@localhost \
--to=johan@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).