linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] arm64: unwind: fix broken exception stack dump
Date: Mon, 24 Jul 2017 12:26:19 +0100	[thread overview]
Message-ID: <20170724112623.26109-1-ard.biesheuvel@linaro.org> (raw)

This fixes an issue in the code that dumps the exception stack. As it
turns out, it doesn't display what we think it does. Please refer to
patch #3 for the details.

Patches #1 and #2 are preparatory patches. Patch #4 removes the sp
member from struct stackframe because it is broken and no longer
needed after patch #3.

Mark and I ran into this issue while working on the vmapped stacks code,
and so these changes are now prerequisites for it, especially given how
dealing with multiple stacks is simplified by these changes.

Ard Biesheuvel (3):
  arm64: unwind: disregard frame.sp when validating frame pointer
  arm64: unwind: reference pt_regs via embedded stack frame
  arm64: unwind: remove sp from struct stackframe

Mark Rutland (1):
  arm64: avoid percpu indirection for irq stack ops

 arch/arm64/include/asm/irq.h        | 39 +++++----------
 arch/arm64/include/asm/ptrace.h     |  1 +
 arch/arm64/include/asm/stacktrace.h |  1 -
 arch/arm64/kernel/asm-offsets.c     |  1 +
 arch/arm64/kernel/entry.S           | 16 +++---
 arch/arm64/kernel/perf_callchain.c  |  1 -
 arch/arm64/kernel/process.c         |  5 +-
 arch/arm64/kernel/ptrace.c          |  2 +-
 arch/arm64/kernel/return_address.c  |  1 -
 arch/arm64/kernel/stacktrace.c      | 51 ++------------------
 arch/arm64/kernel/time.c            |  1 -
 arch/arm64/kernel/traps.c           | 29 ++---------
 12 files changed, 33 insertions(+), 115 deletions(-)

-- 
2.9.3

             reply	other threads:[~2017-07-24 11:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 11:26 Ard Biesheuvel [this message]
2017-07-24 11:26 ` [PATCH 1/4] arm64: avoid percpu indirection for irq stack ops Ard Biesheuvel
2017-07-24 11:26 ` [PATCH 2/4] arm64: unwind: disregard frame.sp when validating frame pointer Ard Biesheuvel
2017-07-24 11:26 ` [PATCH 3/4] arm64: unwind: reference pt_regs via embedded stack frame Ard Biesheuvel
2017-07-24 17:54   ` Mark Rutland
2017-07-24 18:34     ` Ard Biesheuvel
2017-07-24 19:09       ` Ard Biesheuvel
2017-07-25  9:53         ` Mark Rutland
2017-07-25 10:07           ` Ard Biesheuvel
2017-07-25 13:13     ` Will Deacon
2017-07-25 13:58       ` Mark Rutland
2017-07-24 11:26 ` [PATCH 4/4] arm64: unwind: remove sp from struct stackframe Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170724112623.26109-1-ard.biesheuvel@linaro.org \
    --to=ard.biesheuvel@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).