From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq
Date: Tue, 25 Jul 2017 01:55:17 -0700 [thread overview]
Message-ID: <20170725085517.GQ10026@atomide.com> (raw)
In-Reply-To: <20170724095201.21601-1-johan@kernel.org>
* Johan Hovold <johan@kernel.org> [170724 02:53]:
> Since commit a8636c89648a ("PM / Runtime: Don't allow to suspend a
> device with an active child"), which went into 4.10, it is no longer
> permitted to set RPM_SUSPENDED state for a device with active children
> (unless power.ignore_children is set).
>
> This specifically means that the attempts to do just that from the omap
> pm-domain suspend_noirq callback have since been failing whenever a
> child is active, for example:
>
> am335x-usb-childs 47400000.usb: runtime PM trying to suspend
> device but active child
>
> Silence this warning by dropping the broken pm_runtime_set_suspended()
> call from the omap suspend_noirq callback along with the redundant
> pm_runtime_set_active() in resume_noirq.
With this things still work for me for my PM tests on omap3. Device
suspends and resumes just fine hitting off mode during suspend.
Regards,
Tony
prev parent reply other threads:[~2017-07-25 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 9:52 [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq Johan Hovold
2017-07-24 22:16 ` Grygorii Strashko
2017-07-25 7:10 ` Tony Lindgren
2017-07-25 8:56 ` Tony Lindgren
2017-07-25 17:41 ` Grygorii Strashko
2017-07-25 8:24 ` Johan Hovold
2017-07-25 17:48 ` Grygorii Strashko
2017-07-26 7:50 ` Johan Hovold
2017-07-26 8:17 ` Tony Lindgren
2017-07-26 8:35 ` Johan Hovold
2017-08-10 15:08 ` Tony Lindgren
2017-07-25 8:55 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725085517.GQ10026@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).