public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: romain.perier@collabora.com (Romain Perier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v3 2/3] arm: dts: rockchip: Don't set otp-gpio pinctrl by default in rk3288.dtsi
Date: Wed, 26 Jul 2017 15:55:21 +0200	[thread overview]
Message-ID: <20170726135526.475-7-romain.perier@collabora.com> (raw)
In-Reply-To: <20170726135526.475-1-romain.perier@collabora.com>

The tsadc supports two reset methods: the cru and the otp_gpio. All
boards except veyron and the evb simply use the cru-method and reuse the
pin for something else. On the Firefly-RK3288 this is for example the
case with the headphone. To prevent pinctrl-conflicts with these don't
set the otp-gpio pinctrl by default but only in the boards using it.

Signed-off-by: Romain Perier <romain.perier@collabora.com>
---
 arch/arm/boot/dts/rk3288-evb.dtsi    | 4 ++++
 arch/arm/boot/dts/rk3288-veyron.dtsi | 4 ++++
 arch/arm/boot/dts/rk3288.dtsi        | 4 ----
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index 0dec94c3583b..28a69334b2d1 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -290,6 +290,10 @@
 };
 
 &tsadc {
+	pinctrl-names = "init", "default", "sleep";
+	pinctrl-0 = <&otp_gpio>;
+	pinctrl-1 = <&otp_out>;
+	pinctrl-2 = <&otp_gpio>;
 	rockchip,hw-tshut-mode = <0>; /* tshut mode 0:CRU 1:GPIO */
 	rockchip,hw-tshut-polarity = <0>; /* tshut polarity 0:LOW 1:HIGH */
 	status = "okay";
diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index d709fa1847f9..697c9a78cb7e 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -398,6 +398,10 @@
 &tsadc {
 	status = "okay";
 
+	pinctrl-names = "init", "default", "sleep";
+	pinctrl-0 = <&otp_gpio>;
+	pinctrl-1 = <&otp_out>;
+	pinctrl-2 = <&otp_gpio>;
 	rockchip,hw-tshut-mode = <1>; /* tshut mode 0:CRU 1:GPIO */
 	rockchip,hw-tshut-polarity = <1>; /* tshut polarity 0:LOW 1:HIGH */
 };
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 2484f11761ea..3a752c0cbc73 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -541,10 +541,6 @@
 		clock-names = "tsadc", "apb_pclk";
 		resets = <&cru SRST_TSADC>;
 		reset-names = "tsadc-apb";
-		pinctrl-names = "init", "default", "sleep";
-		pinctrl-0 = <&otp_gpio>;
-		pinctrl-1 = <&otp_out>;
-		pinctrl-2 = <&otp_gpio>;
 		#thermal-sensor-cells = <1>;
 		rockchip,hw-tshut-temp = <95000>;
 		status = "disabled";
-- 
2.11.0

  parent reply	other threads:[~2017-07-26 13:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 13:55 [PATCH RESEND v3 0/3] Add support for es8323 and hdmi audio to the firefly-rk3288 Romain Perier
2017-07-26 13:55 ` [PATCH RESEND v3 1/3] SoC: es8328-i2c: Add compatible for ES8323 Romain Perier
2017-07-26 13:55 ` [PATCH RESEND v3 2/3] arm: dts: rockchip: Don't set otp-gpio pinctrl by default in rk3288.dtsi Romain Perier
2017-07-26 13:55 ` [PATCH RESEND v3 3/3] arm: dts: Add support for ES8323 to the Firefly-RK3288 Romain Perier
2017-07-26 13:55 ` [PATCH RESEND v3 0/3] Add support for es8323 and hdmi audio to the firefly-rk3288 Romain Perier
2017-07-26 13:55 ` [PATCH RESEND v3 1/3] SoC: es8328-i2c: Add compatible for ES8323 Romain Perier
2017-07-26 13:55 ` Romain Perier [this message]
2017-07-26 13:55 ` [PATCH RESEND v3 3/3] arm: dts: Add support for ES8323 to the Firefly-RK3288 Romain Perier
2017-07-26 13:55 ` [PATCH RESEND v3 0/3] Add support for es8323 and hdmi audio to the firefly-rk3288 Romain Perier
2017-07-26 13:55 ` [PATCH RESEND v3 1/3] SoC: es8328-i2c: Add compatible for ES8323 Romain Perier
2017-08-03 19:01   ` Rob Herring
2017-08-04  6:44     ` Romain Perier
2017-07-26 13:55 ` [PATCH RESEND v3 2/3] arm: dts: rockchip: Don't set otp-gpio pinctrl by default in rk3288.dtsi Romain Perier
2017-07-26 13:55 ` [PATCH RESEND v3 3/3] arm: dts: Add support for ES8323 to the Firefly-RK3288 Romain Perier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726135526.475-7-romain.perier@collabora.com \
    --to=romain.perier@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox