linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: borneo.antonio@gmail.com (Antonio Borneo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] ASoC: fix unbalanced of_node_get()/of_node_put()
Date: Fri, 28 Jul 2017 01:26:09 +0200	[thread overview]
Message-ID: <20170727232612.23543-1-antonio.borneo@st.com> (raw)
In-Reply-To: <20170725214952.6491-1-borneo.antonio@gmail.com>

From: Antonio Borneo <borneo.antonio@gmail.com>

On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers several
errors at kernel boot, like
OF: ERROR: Bad of_node_put() on /soc/i2s at f7118000/ports/port at 0
OF: ERROR: Bad of_node_put() on /soc/i2s at f7118000/ports/port at 0/endpoint
each followed by stack dump.

Fixed by:
- removing of_node_put() in the body of of_for_each_phandle(){},
  since already provided at each iteration. Add it in case the
  loop is break out;
- adding of_node_get() before calling of_graph_get_port_parent().

Tested with kernel v4.13-rc2 with hikey_defconfig taken from
https://git.linaro.org/people/john.stultz/android-dev.git
branch dev/hikey-mainline-WIP

v1 -> v2:
- modify subject "s/fix balance of/fix unbalanced/";
- split the patch per each individual issue. It also simplify the
  backport;
- add ref to the commit being fixed;
- drop one fix not needed.

Antonio Borneo (3):
  ASoC: fix use of of_node_put() in of_for_each_phandle() loops
  ASoC: soc-core: fix unbalanced of_node_get()/of_node_put()
  ASoC: simple-card-utils: fix unbalanced of_node_get()/of_node_put()

 sound/soc/generic/audio-graph-card.c  | 9 ++++-----
 sound/soc/generic/simple-card-utils.c | 5 +++++
 sound/soc/soc-core.c                  | 5 +++++
 3 files changed, 14 insertions(+), 5 deletions(-)

-- 
1.9.1

  parent reply	other threads:[~2017-07-27 23:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 21:49 [PATCH] ASoC: fix balance of of_node_get()/of_node_put() Antonio Borneo
2017-07-26  1:42 ` [alsa-devel] " Kuninori Morimoto
2017-07-26 11:37 ` Mark Brown
2017-07-27 23:20   ` Antonio Borneo
2017-07-27 23:26 ` Antonio Borneo [this message]
2017-07-27 23:26   ` [PATCH v2 1/3] ASoC: fix use of of_node_put() in of_for_each_phandle() loops Antonio Borneo
2017-07-27 23:26   ` [PATCH v2 2/3] ASoC: soc-core: fix unbalanced of_node_get()/of_node_put() Antonio Borneo
2017-07-27 23:26   ` [PATCH v2 3/3] ASoC: simple-card-utils: " Antonio Borneo
2017-07-28 10:07   ` [PATCH v2 0/3] ASoC: " Mark Brown
2017-07-30 20:34     ` Antonio Borneo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170727232612.23543-1-antonio.borneo@st.com \
    --to=borneo.antonio@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).