linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/9] serial: fsl_lpuart: Use common rs485 device tree parsing function
Date: Sun, 30 Jul 2017 07:50:57 -0700	[thread overview]
Message-ID: <20170730145057.GC18707@kroah.com> (raw)
In-Reply-To: <20170718105948.21986-6-u.kleine-koenig@pengutronix.de>

On Tue, Jul 18, 2017 at 12:59:44PM +0200, Uwe Kleine-K?nig wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
> 
> We just got a common helper for parsing the rs485 specific
> device tree properties. Use it and drop the open coded parser.
> 
> As a side effect this adds support for parsing rs485-rts-delay and
> rs485-rx-during-tx. As the driver doesn't support this though, probing
> fails if these are defined.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/tty/serial/fsl_lpuart.c | 24 ++++++++++++++++++------
>  1 file changed, 18 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
> index 4becfbf35c4c..cac81b143abe 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -2161,6 +2161,24 @@ static int lpuart_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> +	of_get_rs485_mode(np, &sport->port.rs485);

error checking?

Elsewhere in this series as well.

Also, why did you not cc: me on this series so I am sure to see it?

thanks,

greg k-h

  reply	other threads:[~2017-07-30 14:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 10:59 [PATCH v4 0/9] Add and make use of a common rs485 device tree parsing function Uwe Kleine-König
2017-07-18 10:59 ` [PATCH v4 1/9] serial: fsl_lpuart: clear unsupported options in .rs485_config() Uwe Kleine-König
2017-07-18 10:59 ` [PATCH v4 2/9] dt-bindings: serial/rs485: make rs485-rts-delay optional Uwe Kleine-König
2017-07-18 10:59 ` [PATCH v4 3/9] serial: Add common rs485 device tree parsing function Uwe Kleine-König
2017-07-30 14:49   ` Greg KH
2017-07-31  7:42     ` Uwe Kleine-König
2017-07-18 10:59 ` [PATCH v4 4/9] serial: atmel: Use " Uwe Kleine-König
2017-07-30 14:50   ` Greg KH
2017-07-18 10:59 ` [PATCH v4 5/9] serial: fsl_lpuart: " Uwe Kleine-König
2017-07-30 14:50   ` Greg KH [this message]
2017-07-18 10:59 ` [PATCH v4 6/9] serial: omap-serial: " Uwe Kleine-König
2017-07-18 10:59 ` [PATCH v4 7/9] serial: imx: default to half duplex rs485 Uwe Kleine-König
2017-07-18 10:59 ` [PATCH v4 8/9] serial: imx: Use common rs485 device tree parsing function Uwe Kleine-König
2017-07-18 10:59 ` [PATCH v4 9/9] dt-bindings: serial: document rs485 bindings for various devices Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170730145057.GC18707@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).