From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Mon, 31 Jul 2017 13:27:19 +0200 Subject: [PATCH] pinctrl-st: fix of_irq_to_resource() result check In-Reply-To: <20170729180744.873303067@cogentembedded.com> References: <20170729180744.873303067@cogentembedded.com> Message-ID: <20170731112719.GM26667@ulmo> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Jul 29, 2017 at 09:07:07PM +0300, Sergei Shtylyov wrote: > of_irq_to_resource() has recently been fixed to return negative error #'s > along with 0 in case of failure, however the ST driver still only regards > 0 as failure indication -- fix it up. > > Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()") > Signed-off-by: Sergei Shtylyov > > --- > drivers/pinctrl/pinctrl-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-pinctrl/drivers/pinctrl/pinctrl-st.c > =================================================================== > --- linux-pinctrl.orig/drivers/pinctrl/pinctrl-st.c > +++ linux-pinctrl/drivers/pinctrl/pinctrl-st.c > @@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(stru > * [irqN]----> [gpio-bank (n)] > */ > > - if (of_irq_to_resource(np, 0, &irq_res)) { > + if (of_irq_to_resource(np, 0, &irq_res) > 0) { > gpio_irq = irq_res.start; > gpiochip_set_chained_irqchip(&bank->gpio_chip, &st_gpio_irqchip, > gpio_irq, st_gpio_irq_handler); While at it, maybe turn this into of_irq_get() since you only need the interrupt number in the first place? Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: