From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: acpi/gtdt: validate CNTFRQ after having enabled the frame
Date: Tue, 1 Aug 2017 15:57:04 +0100 [thread overview]
Message-ID: <20170801145704.GA27566@leverpostej> (raw)
In-Reply-To: <20170801113120.GD9347@leverpostej>
On Tue, Aug 01, 2017 at 12:31:21PM +0100, Mark Rutland wrote:
> On Tue, Aug 01, 2017 at 12:09:32PM +0100, Ard Biesheuvel wrote:
> > The point here is that CNTFRQ cannot differ between frames. It either
> > returns the value of the base frame or RES0.
>
> Sorry; you had mentioned this before, and I had forgotten.
>
> I'm under the impression that the ARM ARM may be misleading (and
> potentially erroneous) in that regard. In the past I had been told that
> each instance of a CNTFRQ register was independent, and each must be
> writeable for system initialization.
FWIW, I took a look at a Juno R1 with a DSTREAM.
I can independently configure CNTCTLBase.CNTFRQ and CNTBase1.CNTFRQ,
with the latter being RW from the Non-secure side. It seems that
firmware I'm using doesn't bother to initialise either. :/
So regardless of what the architectural intent is, there exist platforms
where these can differ.
I'll try to fix up the patch accordingly, to check all instances.
Thanks,
Mark.
prev parent reply other threads:[~2017-08-01 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 15:10 [PATCH] arm64: acpi/gtdt: validate CNTFRQ after having enabled the frame Ard Biesheuvel
2017-08-01 10:53 ` Mark Rutland
2017-08-01 11:09 ` Ard Biesheuvel
2017-08-01 11:31 ` Mark Rutland
2017-08-01 14:57 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801145704.GA27566@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox