linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jonas.gorski@gmail.com (Jonas Gorski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/8] tty/bcm63xx_uart: allow naming clock in device tree
Date: Wed,  2 Aug 2017 11:34:25 +0200	[thread overview]
Message-ID: <20170802093429.12572-5-jonas.gorski@gmail.com> (raw)
In-Reply-To: <20170802093429.12572-1-jonas.gorski@gmail.com>

Codify using a named clock for the refclk of the uart. This makes it
easier if we might need to add a gating clock (like present on the
BCM6345).

Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---
 Documentation/devicetree/bindings/serial/brcm,bcm6345-uart.txt | 6 ++++++
 drivers/tty/serial/bcm63xx_uart.c                              | 6 ++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/brcm,bcm6345-uart.txt b/Documentation/devicetree/bindings/serial/brcm,bcm6345-uart.txt
index 5c52e5eef16d..8b2b0460259a 100644
--- a/Documentation/devicetree/bindings/serial/brcm,bcm6345-uart.txt
+++ b/Documentation/devicetree/bindings/serial/brcm,bcm6345-uart.txt
@@ -11,6 +11,11 @@ Required properties:
 - clocks: Clock driving the hardware; used to figure out the baud rate
   divisor.
 
+
+Optional properties:
+
+- clock-names: Should be "refclk".
+
 Example:
 
 	uart0: serial at 14e00520 {
@@ -19,6 +24,7 @@ Example:
 		interrupt-parent = <&periph_intc>;
 		interrupts = <2>;
 		clocks = <&periph_clk>;
+		clock-names = "refclk";
 	};
 
 	clocks {
diff --git a/drivers/tty/serial/bcm63xx_uart.c b/drivers/tty/serial/bcm63xx_uart.c
index a2b9376ec861..f227eff28d3a 100644
--- a/drivers/tty/serial/bcm63xx_uart.c
+++ b/drivers/tty/serial/bcm63xx_uart.c
@@ -841,8 +841,10 @@ static int bcm_uart_probe(struct platform_device *pdev)
 	if (!res_irq)
 		return -ENODEV;
 
-	clk = pdev->dev.of_node ? of_clk_get(pdev->dev.of_node, 0) :
-				  clk_get(&pdev->dev, "refclk");
+	clk = clk_get(&pdev->dev, "refclk");
+	if (IS_ERR(clk) && pdev->dev.of_node)
+		clk = of_clk_get(pdev->dev.of_node, 0);
+
 	if (IS_ERR(clk))
 		return -ENODEV;
 
-- 
2.13.2

  parent reply	other threads:[~2017-08-02  9:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02  9:34 [PATCH 0/8] MIPS: BCM63XX: add and use clkdev lookup support Jonas Gorski
2017-08-02  9:34 ` [PATCH 1/8] MIPS: BCM63XX: add " Jonas Gorski
2017-08-02  9:34 ` [PATCH 2/8] MIPS: BCM63XX: provide periph clock as refclk for uart Jonas Gorski
2017-08-02  9:34 ` [PATCH 3/8] tty/bcm63xx_uart: use refclk for the expected clock name Jonas Gorski
2017-08-28 12:51   ` Greg Kroah-Hartman
2017-08-02  9:34 ` Jonas Gorski [this message]
2017-08-10 16:25   ` [PATCH 4/8] tty/bcm63xx_uart: allow naming clock in device tree Rob Herring
2017-09-06 11:01   ` Jonas Gorski
2017-09-06 12:17     ` Greg Kroah-Hartman
2017-09-06 12:37       ` Jonas Gorski
2017-08-02  9:34 ` [PATCH 5/8] MIPS: BCM63XX: provide enet clocks as "enet" to the ethernet devices Jonas Gorski
2017-08-02  9:34 ` [PATCH 6/8] bcm63xx_enet: just use "enet" as the clock name Jonas Gorski
2017-09-06 11:00   ` Jonas Gorski
2017-08-02  9:34 ` [PATCH 7/8] MIPS: BCM63XX: move the HSSPI PLL HZ into its own clock Jonas Gorski
2017-08-02  9:34 ` [PATCH 8/8] MIPS: BMIPS: name the refclk clock for uart Jonas Gorski
2017-08-15 16:20 ` [PATCH 0/8] MIPS: BCM63XX: add and use clkdev lookup support Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802093429.12572-5-jonas.gorski@gmail.com \
    --to=jonas.gorski@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).