linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: miquel.raynal@free-electrons.com (Miquel RAYNAL)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: marvell: armada-3720-espressobin: Add vqmmc regulator for SD slot
Date: Thu, 3 Aug 2017 08:10:11 +0200	[thread overview]
Message-ID: <20170803081011.101dcccd@xps13> (raw)
In-Reply-To: <CAKv0xJx-Jrr8gh30SeFb3A3zRXo2YDG8KtNp7vp25qTqtMfd9g@mail.gmail.com>

Hi,

On Thu, 3 Aug 2017 08:03:24 +0200
Sean Nyekj?r <sean@nyekjaer.dk> wrote:

> On 2 August 2017 at 19:34, Miquel RAYNAL
> <miquel.raynal@free-electrons.com> wrote:
> > Hi,
> >
> > On Sat, 29 Jul 2017 12:44:11 +0200
> > Sean Nyekjaer <sean@nyekjaer.dk> wrote:
> >  
> >> By adding this regulator, the SD cards are usable at higher speed
> >> protocols such as SDR104.
> >>
> >> This patch was tested with an SDHC card compatible with UHS-I.
> >>
> >> Signed-off-by: Sean Nyekjaer <sean@nyekjaer.dk>  
> >
> > The patch does the job, but does not apply as is.  
> Try applying  "[PATCH] arm64: dts: marvell: Add microsd card
> definition for the ESPRESSObin" first :-)

I know, but I was pointing the dependency again because there is at
least one other patch that does the same uSD addition in ESPRESSObin DT
and I do not know which one will be selected by the maintainer.

BR,
Miqu?l

> 
> Br
> Sean
> >
> > Tested-by: Miquel Raynal <miquel.raynal@free-electrons.com>
> >
> > Regards,
> > Miqu?l
> >  
> >> ---
> >>
> >> This patch depends on "[PATCH] arm64: dts: marvell: Add microsd
> >> card definition for the ESPRESSObin"
> >>
> >>  arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 15
> >> ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)
> >>
> >> diff --git
> >> a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> >> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index
> >> 2dadd77e08eb..d5ab5b47f8d4 100644 ---
> >> a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++
> >> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -60,6
> >> +60,19 @@ device_type = "memory"; reg = <0x00000000 0x00000000
> >> 0x00000000 0x20000000>; };
> >> +
> >> +     vcc_sd_reg1: regulator {
> >> +             compatible = "regulator-gpio";
> >> +             regulator-name= "vcc_sd1";
> >> +             regulator-min-microvolt = <1800000>;
> >> +             regulator-max-microvolt = <3300000>;
> >> +
> >> +             gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
> >> +             gpios-states = <0>;
> >> +             states = <1800000 0x1
> >> +                       3300000 0x0>;
> >> +             enable-active-high;
> >> +     };
> >>  };
> >>
> >>  /* J9 */
> >> @@ -82,7 +95,7 @@
> >>       wp-inverted;
> >>       bus-width = <4>;
> >>       cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
> >> -     no-1-8-v;
> >> +     vqmmc-supply = <&vcc_sd_reg1>;
> >>       marvell,pad-type = "sd";
> >>       status = "okay";
> >>  };  
> >
> >
> >
> > --
> > Miquel Raynal, Free Electrons
> > Embedded Linux and Kernel engineering
> > http://free-electrons.com  



-- 
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-08-03  6:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-29 10:44 [PATCH] arm64: dts: marvell: armada-3720-espressobin: Add vqmmc regulator for SD slot Sean Nyekjaer
2017-08-02 17:34 ` Miquel RAYNAL
2017-08-03  6:03   ` Sean Nyekjær
2017-08-03  6:10     ` Miquel RAYNAL [this message]
2017-08-03 12:07       ` Gregory CLEMENT
2017-08-03 12:31         ` Sean Nyekjær

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170803081011.101dcccd@xps13 \
    --to=miquel.raynal@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).