From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi
Date: Thu, 10 Aug 2017 10:01:21 +0200 [thread overview]
Message-ID: <20170810080121.GE16647@verge.net.au> (raw)
In-Reply-To: <12d923ba-184c-ef59-f27b-41a7592a5f93@cogentembedded.com>
On Wed, Aug 09, 2017 at 12:17:06PM +0300, Sergei Shtylyov wrote:
> On 8/8/2017 3:46 PM, Biju Das wrote:
>
> >Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >---
> >This patch has been tested against Linux-next tag 20170727 and renesas-dev branch.
> >This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html
> >
> > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 55 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> >index 14222c72..5c2b140 100644
> >--- a/arch/arm/boot/dts/r8a7743.dtsi
> >+++ b/arch/arm/boot/dts/r8a7743.dtsi
> [...]
> >@@ -436,6 +439,58 @@
> > status = "disabled";
> > };
> >+ i2c6: i2c at e60b0000 {
>
> I'd use iic0 as the label.
I have no preference here other than that we try to be consistent
in DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
>
> >+ /* doesn't need pinmux */
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "renesas,iic-r8a7743",
> >+ "renesas,rcar-gen2-iic",
> >+ "renesas,rmobile-iic";
> >+ reg = <0 0xe60b0000 0 0x425>;
> >+ interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
> >+ clocks = <&cpg CPG_MOD 926>;
> >+ dmas = <&dmac0 0x77>, <&dmac0 0x78>,
> >+ <&dmac1 0x77>, <&dmac1 0x78>;
> >+ dma-names = "tx", "rx", "tx", "rx";
> >+ power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> >+ resets = <&cpg CPG_MOD 926>;
>
> CPG_MOD not needed here, it's not a "clocks" prop.
>
> [...]
>
> MBR, Sergei
>
next prev parent reply other threads:[~2017-08-10 8:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 12:46 [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi Biju Das
2017-08-09 8:56 ` Simon Horman
2017-08-09 9:17 ` Sergei Shtylyov
2017-08-09 9:21 ` Biju Das
2017-08-10 8:01 ` Simon Horman [this message]
2017-08-10 11:24 ` Wolfram Sang
2017-08-10 13:49 ` Chris Paterson
2017-08-11 8:48 ` Simon Horman
2017-08-14 14:15 ` Geert Uytterhoeven
2017-08-22 12:20 ` Sergei Shtylyov
2017-08-14 9:53 ` [PATCH v2] ARM: dts: r8a7743: add " Biju Das
2017-08-22 9:10 ` Chris Paterson
2017-08-22 12:23 ` Sergei Shtylyov
2017-08-30 7:32 ` Simon Horman
2017-08-30 7:46 ` Chris Paterson
2017-09-06 13:52 ` [PATCH v3] ARM: dts: r8a7743: Add " Chris Paterson
2017-09-11 7:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810080121.GE16647@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox