* [PATCH] mtd: physmap_of: Retire Gemini pad control
@ 2017-08-08 19:05 Linus Walleij
2017-08-08 21:44 ` Marek Vasut
2017-08-17 13:04 ` Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2017-08-08 19:05 UTC (permalink / raw)
To: linux-arm-kernel
I wrote a proper pin control driver for the Gemini. Retire this
SoC-specific pad control and rely on the pin controller to manage
this.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/mtd/maps/physmap_of_gemini.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/mtd/maps/physmap_of_gemini.c b/drivers/mtd/maps/physmap_of_gemini.c
index 05b286b5289f..4ed1a6bb4d3c 100644
--- a/drivers/mtd/maps/physmap_of_gemini.c
+++ b/drivers/mtd/maps/physmap_of_gemini.c
@@ -43,13 +43,6 @@
#define FLASH_PARALLEL_HIGH_PIN_CNT (1 << 20) /* else low pin cnt */
-/* Miscellaneous Control Register */
-#define GLOBAL_MISC_CTRL 0x30
-#define FLASH_PADS_MASK 0x07
-#define NAND_PADS_DISABLE BIT(2)
-#define PFLASH_PADS_DISABLE BIT(1)
-#define SFLASH_PADS_DISABLE BIT(0)
-
static const struct of_device_id syscon_match[] = {
{ .compatible = "cortina,gemini-syscon" },
{ },
@@ -102,15 +95,6 @@ int of_flash_probe_gemini(struct platform_device *pdev,
map->bankwidth * 8);
}
- /* Activate parallel (NOR flash) mode */
- ret = regmap_update_bits(rmap, GLOBAL_MISC_CTRL,
- FLASH_PADS_MASK,
- SFLASH_PADS_DISABLE | NAND_PADS_DISABLE);
- if (ret) {
- dev_err(dev, "unable to set up physmap pads\n");
- return -ENODEV;
- }
-
dev_info(&pdev->dev, "initialized Gemini-specific physmap control\n");
return 0;
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] mtd: physmap_of: Retire Gemini pad control
2017-08-08 19:05 [PATCH] mtd: physmap_of: Retire Gemini pad control Linus Walleij
@ 2017-08-08 21:44 ` Marek Vasut
2017-08-17 13:04 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2017-08-08 21:44 UTC (permalink / raw)
To: linux-arm-kernel
On 08/08/2017 09:05 PM, Linus Walleij wrote:
> I wrote a proper pin control driver for the Gemini. Retire this
> SoC-specific pad control and rely on the pin controller to manage
> this.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
Thanks!
> ---
> drivers/mtd/maps/physmap_of_gemini.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/mtd/maps/physmap_of_gemini.c b/drivers/mtd/maps/physmap_of_gemini.c
> index 05b286b5289f..4ed1a6bb4d3c 100644
> --- a/drivers/mtd/maps/physmap_of_gemini.c
> +++ b/drivers/mtd/maps/physmap_of_gemini.c
> @@ -43,13 +43,6 @@
>
> #define FLASH_PARALLEL_HIGH_PIN_CNT (1 << 20) /* else low pin cnt */
>
> -/* Miscellaneous Control Register */
> -#define GLOBAL_MISC_CTRL 0x30
> -#define FLASH_PADS_MASK 0x07
> -#define NAND_PADS_DISABLE BIT(2)
> -#define PFLASH_PADS_DISABLE BIT(1)
> -#define SFLASH_PADS_DISABLE BIT(0)
> -
> static const struct of_device_id syscon_match[] = {
> { .compatible = "cortina,gemini-syscon" },
> { },
> @@ -102,15 +95,6 @@ int of_flash_probe_gemini(struct platform_device *pdev,
> map->bankwidth * 8);
> }
>
> - /* Activate parallel (NOR flash) mode */
> - ret = regmap_update_bits(rmap, GLOBAL_MISC_CTRL,
> - FLASH_PADS_MASK,
> - SFLASH_PADS_DISABLE | NAND_PADS_DISABLE);
> - if (ret) {
> - dev_err(dev, "unable to set up physmap pads\n");
> - return -ENODEV;
> - }
> -
> dev_info(&pdev->dev, "initialized Gemini-specific physmap control\n");
>
> return 0;
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] mtd: physmap_of: Retire Gemini pad control
2017-08-08 19:05 [PATCH] mtd: physmap_of: Retire Gemini pad control Linus Walleij
2017-08-08 21:44 ` Marek Vasut
@ 2017-08-17 13:04 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2017-08-17 13:04 UTC (permalink / raw)
To: linux-arm-kernel
Le Tue, 8 Aug 2017 21:05:10 +0200,
Linus Walleij <linus.walleij@linaro.org> a ?crit :
> I wrote a proper pin control driver for the Gemini. Retire this
> SoC-specific pad control and rely on the pin controller to manage
> this.
>
Applied to l2-mtd/master.
Thanks,
Boris
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/mtd/maps/physmap_of_gemini.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/mtd/maps/physmap_of_gemini.c b/drivers/mtd/maps/physmap_of_gemini.c
> index 05b286b5289f..4ed1a6bb4d3c 100644
> --- a/drivers/mtd/maps/physmap_of_gemini.c
> +++ b/drivers/mtd/maps/physmap_of_gemini.c
> @@ -43,13 +43,6 @@
>
> #define FLASH_PARALLEL_HIGH_PIN_CNT (1 << 20) /* else low pin cnt */
>
> -/* Miscellaneous Control Register */
> -#define GLOBAL_MISC_CTRL 0x30
> -#define FLASH_PADS_MASK 0x07
> -#define NAND_PADS_DISABLE BIT(2)
> -#define PFLASH_PADS_DISABLE BIT(1)
> -#define SFLASH_PADS_DISABLE BIT(0)
> -
> static const struct of_device_id syscon_match[] = {
> { .compatible = "cortina,gemini-syscon" },
> { },
> @@ -102,15 +95,6 @@ int of_flash_probe_gemini(struct platform_device *pdev,
> map->bankwidth * 8);
> }
>
> - /* Activate parallel (NOR flash) mode */
> - ret = regmap_update_bits(rmap, GLOBAL_MISC_CTRL,
> - FLASH_PADS_MASK,
> - SFLASH_PADS_DISABLE | NAND_PADS_DISABLE);
> - if (ret) {
> - dev_err(dev, "unable to set up physmap pads\n");
> - return -ENODEV;
> - }
> -
> dev_info(&pdev->dev, "initialized Gemini-specific physmap control\n");
>
> return 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-17 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-08 19:05 [PATCH] mtd: physmap_of: Retire Gemini pad control Linus Walleij
2017-08-08 21:44 ` Marek Vasut
2017-08-17 13:04 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).