linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 2/3] rtc: Add Realtek RTD1295
Date: Sun, 20 Aug 2017 17:40:17 +0200	[thread overview]
Message-ID: <20170820154017.GD24150@lunn.ch> (raw)
In-Reply-To: <20170820013632.18375-3-afaerber@suse.de>

> +static void rtd119x_rtc_set_enabled(struct device *dev, bool enable)
> +{
> +	struct rtd119x_rtc *data = dev_get_drvdata(dev);
> +	u32 val;
> +
> +	val = readl_relaxed(data->base + RTD_RTCEN);
> +	dev_info(dev, "%s: rtcen = 0x%08x\n", __func__, val);

dev_dbg()?

> +static int rtd119x_rtc_open(struct device *dev)
> +{
> +	struct rtd119x_rtc *data = dev_get_drvdata(dev);
> +	u32 val;
> +	int ret;
> +
> +	ret = clk_prepare_enable(data->clk);
> +	if (ret)
> +		return ret;
> +
> +	val = readl_relaxed(data->base + RTD_RTCACR);
> +	dev_info(dev, "rtcacr = 0x%08x\n", val);

dev_dbg()?

	Andrew

  parent reply	other threads:[~2017-08-20 15:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-20  1:36 [RFC 0/3] arm64: Realtek RTD1295 RTC Andreas Färber
2017-08-20  1:36 ` [RFC 1/3] dt-bindings: rtc: Add Realtek RTD1295 Andreas Färber
2017-08-23  0:29   ` Rob Herring
2017-08-27 10:41     ` Andreas Färber
2017-08-27 13:47       ` Andrew Lunn
2017-08-27 17:26         ` Andreas Färber
2017-08-27 19:07           ` Alexandre Belloni
2017-08-20  1:36 ` [RFC 2/3] " Andreas Färber
2017-08-20  8:32   ` Alexandre Belloni
2017-08-20 21:10     ` Andreas Färber
2017-08-23  1:18       ` Alexandre Belloni
2017-08-20 15:40   ` Andrew Lunn [this message]
2017-08-20 21:12     ` Andreas Färber
2017-08-20  1:36 ` [RFC 3/3] arm64: dts: realtek: Add RTD1295 RTC node Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170820154017.GD24150@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).