From: leo.yan@linaro.org (Leo Yan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] doc: coresight: correct usage for '/dev/cpu_dma_latency'
Date: Wed, 23 Aug 2017 19:08:10 +0800 [thread overview]
Message-ID: <20170823110810.GA28579@leoy-linaro> (raw)
In-Reply-To: <c6d08eff-d92e-9cd2-5c33-1bf67711471c@arm.com>
Hi Sudeep,
On Wed, Aug 23, 2017 at 10:17:06AM +0100, Sudeep Holla wrote:
>
> On 23/08/17 08:23, Leo Yan wrote:
> > In the coresight CPU debug document it suggests to use 'echo' command
> > to set latency request to /dev/cpu_dma_latency so can disable all CPU
> > idle states, but in fact this doesn't work.
> >
> > This is because when the command 'echo' exits, it releases the device
> > node's file descriptor and the kernel release function removes the QoS
> > constraint; finally when the command 'echo' finished there have no
> > constraint imposed on cpu_dma_latency.
> >
> > This patch changes to use 'exec' to access '/dev/cpu_dma_latency', the
> > command 'exec' can avoid the file descriptor to be closed so we can
> > keep the constraint on cpu_dma_latency.
> >
> > This patch also corrects the description when set latency = 0uS, in
> > this case the idle state0 still can be selected by CPUIdle governor so
> > this means on ARM platform the 'WFI' state is still enabled, but all
> > other deeper states have been disabled so CPUs will not be powered off.
> >
>
>
> IMO, we should just refer to cpuidle and PM QoS documents from here so
> that any updates or changes in those documents are observed. Having a
> copy of the text may result in it getting obsolete.
Agree, we should point to below docs:
Documentation/power/pm_qos_interface.txt, section 'From user mode';
Documentation/cpuidle/sysfs.txt;
Thanks for good suggestion.
> --
> Regards,
> Sudeep
next prev parent reply other threads:[~2017-08-23 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 7:23 [PATCH] doc: coresight: correct usage for '/dev/cpu_dma_latency' Leo Yan
2017-08-23 9:17 ` Sudeep Holla
2017-08-23 11:08 ` Leo Yan [this message]
2017-08-23 16:05 ` Kim Phillips
2017-09-15 10:23 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823110810.GA28579@leoy-linaro \
--to=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).