From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-next regression caused by "gpiolib: request the gpio before querying its direction"
Date: Wed, 30 Aug 2017 16:32:55 +0200 [thread overview]
Message-ID: <20170830163255.4e7c1422@windsurf.lan> (raw)
In-Reply-To: <442accaa-15a0-4efb-4e5c-cebca7140213@codeaurora.org>
Hello,
On Wed, 30 Aug 2017 09:22:55 -0500, Timur Tabi wrote:
> No, that's it. The question is, what exactly should the 'request'
> function do? Should it be modifying the hardware to satisfy the
> request? When I wrote my patch, I assumed that it wouldn't. I thought
> that request simply answered the question, "can I touch this GPIO"?
No, it also muxes the pin in GPIO, and you can see the "reference"
implementation pinctrl-single also does it.
Let's see what Linus W. has to say about the semantic of the "request"
operation.
But if we change the semantic of "request" to no longer mux the hardware
as GPIO, then you will also have regressions, because there are plenty
of GPIOs that are requested, but not explicitly muxed as GPIOs in the
DT, precisely because today requesting a GPIO is sufficient to have it
re-muxed as GPIO at the pinctrl level.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-30 14:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 9:24 linux-next regression caused by "gpiolib: request the gpio before querying its direction" Thomas Petazzoni
2017-08-30 12:31 ` Timur Tabi
2017-08-30 13:59 ` Gregory CLEMENT
2017-08-30 14:17 ` Thomas Petazzoni
2017-08-30 14:22 ` Timur Tabi
2017-08-30 14:32 ` Thomas Petazzoni [this message]
2017-08-30 16:24 ` jmondi
2017-08-30 19:38 ` Geert Uytterhoeven
2017-08-31 7:08 ` Linus Walleij
2017-08-31 7:18 ` Thomas Petazzoni
2017-08-31 7:30 ` Geert Uytterhoeven
2017-08-31 9:22 ` Russell King - ARM Linux
2017-08-31 9:39 ` Thomas Petazzoni
2017-08-31 18:39 ` Timur Tabi
2017-08-31 9:50 ` Geert Uytterhoeven
2017-08-31 13:05 ` Timur Tabi
2017-08-31 10:08 ` Maxime Ripard
2017-08-31 7:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830163255.4e7c1422@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox