From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clk: mb86s7x: Drop non-building driver
Date: Fri, 1 Sep 2017 13:32:01 -0700 [thread overview]
Message-ID: <20170901203201.GB21656@codeaurora.org> (raw)
In-Reply-To: <20170824225237.21485-1-afaerber@suse.de>
On 08/25, Andreas F?rber wrote:
> It fails to build once we introduce the ARCH_MB86S7X Kconfig symbol:
>
> drivers/clk/clk-mb86s7x.c:27:10: fatal error: soc/mb86s7x/scb_mhu.h: No such file or directory
> #include <soc/mb86s7x/scb_mhu.h>
> ^~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
>
> And when commenting out that line, we get:
>
> drivers/clk/clk-mb86s7x.c: In function 'crg_gate_control':
> drivers/clk/clk-mb86s7x.c:72:8: error: implicit declaration of function 'mb86s7x_send_packet' [-Werror=implicit-function-declaration]
> ret = mb86s7x_send_packet(CMD_PERI_CLOCK_GATE_SET_REQ,
> ^~~~~~~~~~~~~~~~~~~
> drivers/clk/clk-mb86s7x.c:72:28: error: 'CMD_PERI_CLOCK_GATE_SET_REQ' undeclared (first use in this function)
> ret = mb86s7x_send_packet(CMD_PERI_CLOCK_GATE_SET_REQ,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/clk-mb86s7x.c:72:28: note: each undeclared identifier is reported only once for each function it appears in
> drivers/clk/clk-mb86s7x.c: In function 'crg_rate_control':
> drivers/clk/clk-mb86s7x.c:116:10: error: 'CMD_PERI_CLOCK_RATE_SET_REQ' undeclared (first use in this function)
> code = CMD_PERI_CLOCK_RATE_SET_REQ;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/clk-mb86s7x.c:121:10: error: 'CMD_PERI_CLOCK_RATE_GET_REQ' undeclared (first use in this function); did you mean 'CMD_PERI_CLOCK_RATE_SET_REQ'?
> code = CMD_PERI_CLOCK_RATE_GET_REQ;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> CMD_PERI_CLOCK_RATE_SET_REQ
> drivers/clk/clk-mb86s7x.c: In function 'mhu_cluster_rate':
> drivers/clk/clk-mb86s7x.c:276:10: error: 'CMD_CPU_CLOCK_RATE_GET_REQ' undeclared (first use in this function)
> code = CMD_CPU_CLOCK_RATE_GET_REQ;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/clk-mb86s7x.c:278:10: error: 'CMD_CPU_CLOCK_RATE_SET_REQ' undeclared (first use in this function); did you mean 'CMD_CPU_CLOCK_RATE_GET_REQ'?
> code = CMD_CPU_CLOCK_RATE_SET_REQ;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> CMD_CPU_CLOCK_RATE_GET_REQ
> cc1: some warnings being treated as errors
> scripts/Makefile.build:302: recipe for target
> 'drivers/clk/clk-mb86s7x.o' failed
> make[2]: *** [drivers/clk/clk-mb86s7x.o] Error 1
>
> Remove the driver for now.
>
> Signed-off-by: Andreas F?rber <afaerber@suse.de>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-09-01 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 22:52 [PATCH v2] clk: mb86s7x: Drop non-building driver Andreas Färber
2017-09-01 20:32 ` Stephen Boyd [this message]
2017-09-04 15:46 ` Andreas Färber
2017-09-05 18:46 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901203201.GB21656@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).