From: cdall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PULL 1/8] KVM: arm/arm64: Fix bug in advertising KVM_CAP_MSI_DEVID capability
Date: Tue, 5 Sep 2017 16:52:00 +0200 [thread overview]
Message-ID: <20170905145207.18447-2-cdall@linaro.org> (raw)
In-Reply-To: <20170905145207.18447-1-cdall@linaro.org>
From: Shanker Donthineni <shankerd@codeaurora.org>
Commit 0e4e82f154e3 ("KVM: arm64: vgic-its: Enable ITS emulation as
a virtual MSI controller") tried to advertise KVM_CAP_MSI_DEVID, but
the code logic was not updating the dist->msis_require_devid field
correctly. If hypervisor tool creates the ITS device after VGIC
initialization then we don't advertise KVM_CAP_MSI_DEVID capability.
Update the field msis_require_devid to true inside vgic_its_create()
to fix the issue.
Cc: stable at vger.kernel.org
Fixes: 0e4e82f154e3 ("vgic-its: Enable ITS emulation as a virtual MSI controller")
Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
virt/kvm/arm/vgic/vgic-init.c | 3 ---
virt/kvm/arm/vgic/vgic-its.c | 1 +
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/virt/kvm/arm/vgic/vgic-init.c b/virt/kvm/arm/vgic/vgic-init.c
index 3a0b899..5801261 100644
--- a/virt/kvm/arm/vgic/vgic-init.c
+++ b/virt/kvm/arm/vgic/vgic-init.c
@@ -285,9 +285,6 @@ int vgic_init(struct kvm *kvm)
if (ret)
goto out;
- if (vgic_has_its(kvm))
- dist->msis_require_devid = true;
-
kvm_for_each_vcpu(i, vcpu, kvm)
kvm_vgic_vcpu_enable(vcpu);
diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
index 2dff288..aa6b68d 100644
--- a/virt/kvm/arm/vgic/vgic-its.c
+++ b/virt/kvm/arm/vgic/vgic-its.c
@@ -1598,6 +1598,7 @@ static int vgic_its_create(struct kvm_device *dev, u32 type)
INIT_LIST_HEAD(&its->device_list);
INIT_LIST_HEAD(&its->collection_list);
+ dev->kvm->arch.vgic.msis_require_devid = true;
dev->kvm->arch.vgic.has_its = true;
its->enabled = false;
its->dev = dev;
--
2.9.0
next prev parent reply other threads:[~2017-09-05 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 14:51 [PULL 0/8] KVM/ARM Changes for v4.14 Christoffer Dall
2017-09-05 14:52 ` Christoffer Dall [this message]
2017-09-05 14:52 ` [PULL 2/8] KVM: arm/arm64: PMU: Fix overflow interrupt injection Christoffer Dall
2017-09-05 14:52 ` [PULL 3/8] KVM: arm/arm64: Handle hva aging while destroying the vm Christoffer Dall
2017-09-05 14:52 ` [PULL 4/8] KVM: arm/arm64: Fix guest external abort matching Christoffer Dall
2017-09-05 14:52 ` [PULL 5/8] KVM: arm/arm64: vgic: constify seq_operations and file_operations Christoffer Dall
2017-09-05 14:52 ` [PULL 6/8] KVM: arm/arm64: vITS: Drop its_ite->lpi field Christoffer Dall
2017-09-05 14:52 ` [PULL 7/8] KVM: arm/arm64: Extract GICv3 max APRn index calculation Christoffer Dall
2017-09-05 14:52 ` [PULL 8/8] KVM: arm/arm64: Support uaccess of GICC_APRn Christoffer Dall
2017-09-05 15:07 ` [PULL 0/8] KVM/ARM Changes for v4.14 Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905145207.18447-2-cdall@linaro.org \
--to=cdall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).