From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Fri, 8 Sep 2017 09:39:54 +0530 Subject: [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support In-Reply-To: <20170907193732.GB11006@kroah.com> References: <1501583880-32072-1-git-send-email-anup.patel@broadcom.com> <1501583880-32072-16-git-send-email-anup.patel@broadcom.com> <20170817080142.GC3053@localhost> <20170818052613.GE3053@localhost> <20170907193732.GB11006@kroah.com> Message-ID: <20170908040954.GB3053@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Sep 07, 2017 at 09:37:32PM +0200, Greg KH wrote: > On Fri, Aug 18, 2017 at 10:56:13AM +0530, Vinod Koul wrote: > > On Fri, Aug 18, 2017 at 10:33:54AM +0530, Anup Patel wrote: > > > On Thu, Aug 17, 2017 at 1:31 PM, Vinod Koul wrote: > > > > On Tue, Aug 01, 2017 at 04:07:59PM +0530, Anup Patel wrote: > > > > why fail, debugfs should be an optional thingy, why would you want to fail here? > > > > > > Yes, we are handling the case when debugfs is not available > > > and skipping debugfs gracefully. > > > > > > If debugfs is available then failure of debugfs_create_dir() > > > should be reported. > > > > reported yes, bailing out on that err no.. > > Reported, no. You should _never_ care about the return value of a > debugfs call. Never check it, just move on ad keep on going. It > doesn't matter. Agreed that makes more sense. The driver was checking and bailing out, I advised against that :) -- ~Vinod