From: romain.izard.pro@gmail.com (Romain Izard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 05/10] mtd: nand: atmel: Report PMECC failures as errors
Date: Fri, 8 Sep 2017 17:35:59 +0200 [thread overview]
Message-ID: <20170908153604.28383-6-romain.izard.pro@gmail.com> (raw)
In-Reply-To: <20170908153604.28383-1-romain.izard.pro@gmail.com>
It is not normal for the PMECC to fail when trying to fix ECC errors.
Report these cases as errors.
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
drivers/mtd/nand/atmel/pmecc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c
index 8d1208f38025..2a23f1ff945f 100644
--- a/drivers/mtd/nand/atmel/pmecc.c
+++ b/drivers/mtd/nand/atmel/pmecc.c
@@ -687,6 +687,8 @@ static int atmel_pmecc_err_location(struct atmel_pmecc_user *user)
* Number of roots does not match the degree of smu
* unable to correct error.
*/
+ dev_err(pmecc->dev,
+ "PMECC: Impossible to calculate error location.\n");
return -EBADMSG;
}
@@ -729,7 +731,7 @@ int atmel_pmecc_correct_sector(struct atmel_pmecc_user *user, int sector,
ptr = ecc + byte - sectorsize;
area = "ECC";
} else {
- dev_dbg(pmecc->dev,
+ dev_err(pmecc->dev,
"Invalid errpos value (%d, max is %d)\n",
errpos, (sectorsize + eccbytes) * 8);
return -EINVAL;
--
2.11.0
next prev parent reply other threads:[~2017-09-08 15:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 15:35 [PATCH v1 00/10] Various patches for SAMA5D2 backup mode Romain Izard
2017-09-08 15:35 ` [PATCH v1 01/10] clk: at91: pmc: Wait for clocks when resuming Romain Izard
2017-09-13 12:15 ` Nicolas Ferre
2017-09-14 16:15 ` Romain Izard
2017-09-22 12:12 ` Nicolas Ferre
2017-09-08 15:35 ` [PATCH v1 02/10] clk: at91: pmc: Save SCSR during suspend Romain Izard
2017-09-13 12:10 ` Nicolas Ferre
2017-09-08 15:35 ` [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks Romain Izard
2017-09-13 12:29 ` Nicolas Ferre
2017-09-13 17:03 ` Alexandre Belloni
2017-09-14 7:41 ` romain izard
2017-09-14 9:38 ` Nicolas Ferre
2017-09-08 15:35 ` [PATCH v1 04/10] mtd: nand: atmel: Avoid ECC errors when leaving backup mode Romain Izard
2017-09-08 15:35 ` Romain Izard [this message]
2017-09-08 15:36 ` [PATCH v1 06/10] ehci-atmel: Power down during suspend is normal Romain Izard
2017-09-08 15:36 ` [PATCH v1 07/10] iio:adc:at91-sama5d2: Support backup mode Romain Izard
2017-09-08 16:03 ` Nicolas Ferre
2017-09-08 16:21 ` Romain Izard
2017-09-08 15:36 ` [PATCH v1 08/10] pwm: atmel-tcb: " Romain Izard
2017-09-08 15:36 ` [PATCH v1 09/10] atmel_flexcom: " Romain Izard
2017-09-08 15:36 ` [PATCH v1 10/10] tty/serial: atmel: Prevent a warning on suspend Romain Izard
2017-09-11 9:52 ` Romain Izard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908153604.28383-6-romain.izard.pro@gmail.com \
--to=romain.izard.pro@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).