From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: bulk: call of_clk_get() when id is NULL
Date: Mon, 11 Sep 2017 13:57:46 +0800 [thread overview]
Message-ID: <20170911055745.GF3787@dragon> (raw)
In-Reply-To: <AM3PR04MB3065706564AA81D56E03E4580680@AM3PR04MB306.eurprd04.prod.outlook.com>
On Mon, Sep 11, 2017 at 04:51:28AM +0000, A.s. Dong wrote:
> Hi Shawn,
>
> > -----Original Message-----
> > From: Stephen Boyd [mailto:sboyd at codeaurora.org]
> > Sent: Thursday, August 31, 2017 1:27 PM
> > To: A.s. Dong
> > Cc: Shawn Guo; Michael Turquette; linux-clk at vger.kernel.org; linux-arm-
> > kernel at lists.infradead.org; Shawn Guo
> > Subject: Re: [PATCH] clk: bulk: call of_clk_get() when id is NULL
> >
> > On 08/30, A.s. Dong wrote:
>
> [...]
>
> > > Flags may be better used for extending per clk feature support in the
> > future.
> > >
> > > IMHO how about implement a of_clk_bulk_get() to handle this issue as
> > > we already have a of_clk_get?
> > > e.g.
> > >
> > > int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
> > > struct clk_bulk_data *clks) {
> > > for (i = 0; i < num_clks; i++) {
> > > clks[i].clk = of_clk_get(dev, clks[i].id); ...
> > >
> > > }
> > >
> > > Then it's less intrusive.
> > >
> >
> > This looks ok too. Go ahead and send this version instead.
> >
>
> I did not see you send a update version.
> If you will not do it, would you mind me to help send it with a Reported-by: tag from you?
Sure, go ahead.
Shawn
next prev parent reply other threads:[~2017-09-11 5:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 1:50 [PATCH] clk: bulk: call of_clk_get() when id is NULL Shawn Guo
2017-08-09 17:33 ` Stephen Boyd
2017-08-10 1:31 ` Shawn Guo
2017-08-13 14:18 ` Shawn Guo
2017-08-30 15:31 ` A.s. Dong
2017-08-31 5:26 ` Stephen Boyd
2017-09-11 4:51 ` A.s. Dong
2017-09-11 5:57 ` Shawn Guo [this message]
2017-08-31 7:01 ` Shawn Guo
2017-08-31 7:12 ` A.s. Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170911055745.GF3787@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).