From: dianders@chromium.org (Douglas Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/4] phy: rockchip-typec: Set "flip" properly; some cleanups; fix swing
Date: Tue, 19 Sep 2017 12:56:26 -0700 [thread overview]
Message-ID: <20170919195630.18747-1-dianders@chromium.org> (raw)
When connecting to certain DP monitors it was observed that only one
of the two orientations of the type C to DP cable would work.
Debugging showed that the problem was that we needed to set the type C
"flip" state earlier. Once we did this, problems went away.
While trying to dig into this problem and some others, I found that
the proper documentation for the Type C PHY was available to me. This
allowed me to cleanup the magic numbers in the funtion that I was
touching and also fix a few minor issues that (luckily) haven't caused
any problems yet.
I also found that aux channel communications were flaky on some
adapters until I adjusted the voltage swing.
For this series I've added Chris Zhong's Reviewed-by tags to some of
the patches since he gave a +1 to nearly identical patches on the
Chrome OS gerrit and I didn't think he'd mind me carrying his tag. If
folks would rather I didn't do that, please yell.
Changes in v2:
- Removed extra blank line
- Voltage swing patch new for v2.
Douglas Anderson (4):
phy: rockchip-typec: Set the AUX channel flip state earlier
phy: rockchip-typec: Avoid magic numbers + add delays in aux calib
phy: rockchip-typec: Do the calibration more correctly
phy: rockchip-typec: Don't set the aux voltage swing to 400 mV
drivers/phy/rockchip/phy-rockchip-typec.c | 246 ++++++++++++++++++++++++------
1 file changed, 201 insertions(+), 45 deletions(-)
--
2.14.1.690.gbb1197296e-goog
next reply other threads:[~2017-09-19 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 19:56 Douglas Anderson [this message]
2017-09-19 19:56 ` [PATCH v2 1/4] phy: rockchip-typec: Set the AUX channel flip state earlier Douglas Anderson
2017-09-19 19:56 ` [PATCH v2 2/4] phy: rockchip-typec: Avoid magic numbers + add delays in aux calib Douglas Anderson
2017-09-19 19:56 ` [PATCH v2 3/4] phy: rockchip-typec: Do the calibration more correctly Douglas Anderson
2017-09-19 19:56 ` [PATCH v2 4/4] phy: rockchip-typec: Don't set the aux voltage swing to 400 mV Douglas Anderson
2017-09-21 10:36 ` [PATCH v2 0/4] phy: rockchip-typec: Set "flip" properly; some cleanups; fix swing Kishon Vijay Abraham I
2017-09-22 16:45 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919195630.18747-1-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).