From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Fri, 22 Sep 2017 11:54:06 +0100 Subject: [PATCH] drivers/perf: arm_pmu_acpi: Release memory obtained by kasprintf In-Reply-To: References: Message-ID: <20170922105405.GD23365@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Sep 20, 2017 at 12:26:38PM +0530, Arvind Yadav wrote: > Free memory region, if arm_pmu_acpi_probe is not successful. > > Signed-off-by: Arvind Yadav > --- > drivers/perf/arm_pmu_acpi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c > index 0a9b787..3303dd8 100644 > --- a/drivers/perf/arm_pmu_acpi.c > +++ b/drivers/perf/arm_pmu_acpi.c > @@ -235,6 +235,7 @@ int arm_pmu_acpi_probe(armpmu_init_fn init_fn) > ret = armpmu_register(pmu); > if (ret) { > pr_warn("Failed to register PMU for CPU%d\n", cpu); > + kfree(pmu->name); > return ret; > } > } It's a bit weird that we bail out of the loop on the first failing CPU, but you've not changed that behaviour so your patch looks fine in isolation: Acked-by: Will Deacon Catalin: can you pick this up as a fix, please? Will