From: daniel@ffwll.ch (Daniel Vetter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"
Date: Tue, 26 Sep 2017 07:12:41 +0200 [thread overview]
Message-ID: <20170926051241.rwzpxlk4sfju7ctv@phenom.ffwll.local> (raw)
In-Reply-To: <d2298979-3094-744c-3d28-76a0ba4a1137@rock-chips.com>
On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote:
> On 2017?09?21? 06:29, Thomas Meyer wrote:
> > Use vma_pages function on vma object instead of explicit computation.
> > Found by coccinelle spatch "api/vma_pages.cocci"
> >
> > Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> > ---
> Looks good for me:
> Acked-by: Mark Yao <mark.yao@rock-chips.com>
Once more a maintainer who acks a patch and doesn't push it. This is
really confusing, who exactly do you expect to handle this patch for you?
Please push to drm-misc-next (also for future patches), thanks.
-Daniel
>
> >
> > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_
> > {
> > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
> > unsigned int i, count = obj->size >> PAGE_SHIFT;
> > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> > + unsigned long user_count = vma_pages(vma);
> > unsigned long uaddr = vma->vm_start;
> > unsigned long offset = vma->vm_pgoff;
> > unsigned long end = user_count + offset;
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
> >
> >
> >
>
> --
> ?ark Yao
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2017-09-26 5:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1505946334393-568186305-0-diffsplit-thomas@m3y3r.de>
2017-09-20 22:29 ` [PATCH 2/7] arm64: Cocci spatch "vma_pages" Thomas Meyer
2017-09-26 11:57 ` Robin Murphy
2017-09-20 22:29 ` [PATCH 7/7] drm/rockchip: " Thomas Meyer
2017-09-21 1:02 ` Mark yao
2017-09-26 5:12 ` Daniel Vetter [this message]
2017-09-26 6:33 ` Mark yao
2017-09-26 8:08 ` Daniel Vetter
2017-09-20 22:29 ` [PATCH 1/7] ARM: dma-mapping: " Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926051241.rwzpxlk4sfju7ctv@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox