From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Thu, 28 Sep 2017 09:54:47 +0100 Subject: [PATCH] arm64: consistently log boot/secondary CPU IDs In-Reply-To: <1506520238-8306-1-git-send-email-mark.rutland@arm.com> References: <1506520238-8306-1-git-send-email-mark.rutland@arm.com> Message-ID: <20170928085446.GB19060@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Sep 27, 2017 at 02:50:38PM +0100, Mark Rutland wrote: > Currently we inconsistently log identifying information for the boot CPU > and secondary CPUs. For the boot CPU, we log the MIDR and MPIDR across > separate messages, whereas for the secondary CPUs we only log the MIDR. > > In some cases, it would be useful to know the MPIDR of secondary CPUs, > and it would be nice for these messages to be consistent. > > This patch ensures that in the primary and secondary boot paths, we log > both the MPIDR and MIDR in a single message, with a consistent format. > the MPIDR is consistently padded to 10 hex characters to cover Aff3 in > bits 39:32, so that IDs can be compared easily. > > The newly redundant message in setup_arch() is removed. > > Signed-off-by: Mark Rutland > Cc: Al Stone > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/kernel/setup.c | 5 ++--- > arch/arm64/kernel/smp.c | 6 ++++-- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index d4b7405..819c1d1 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -103,7 +103,8 @@ void __init smp_setup_processor_id(void) > * access percpu variable inside lock_release > */ > set_my_cpu_offset(0); > - pr_info("Booting Linux on physical CPU 0x%lx\n", (unsigned long)mpidr); > + pr_info("Booting Linux on physical CPU 0x%010lx [%08x]\n", > + (unsigned long)mpidr, read_cpuid_id()); We should probably be consistent in whether or not we include the '0x' prefix for these hex numbers, otherwise it could get confusing. I don't mind which way we go. Will