From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] regulator: axp20x: Fix poly-phase bit offset for AXP803 DCDC5/6
Date: Fri, 29 Sep 2017 11:25:08 +0800 [thread overview]
Message-ID: <20170929032514.31727-2-wens@csie.org> (raw)
In-Reply-To: <20170929032514.31727-1-wens@csie.org>
The bit offset used to check if DCDC5 and DCDC6 are tied together in
poly-phase output is wrong. It was checking against a reserved bit,
which is always false.
In reality, neither the reference design layout nor actually produced
boards tie these two buck regulators together. But we should still
fix it, just in case.
Fixes: 1dbe0ccb0631 ("regulator: axp20x-regulator: add support for AXP803")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Tested-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
drivers/regulator/axp20x-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index f18b36dd57dd..376a99b7cf5d 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -590,7 +590,7 @@ static bool axp20x_is_polyphase_slave(struct axp20x_dev *axp20x, int id)
case AXP803_DCDC3:
return !!(reg & BIT(6));
case AXP803_DCDC6:
- return !!(reg & BIT(7));
+ return !!(reg & BIT(5));
}
break;
--
2.14.2
next prev parent reply other threads:[~2017-09-29 3:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 3:25 [PATCH 0/7] regulator: axp20x: Add support for AXP813/818 regulators Chen-Yu Tsai
2017-09-29 3:25 ` Chen-Yu Tsai [this message]
2017-09-29 8:33 ` [PATCH 1/7] regulator: axp20x: Fix poly-phase bit offset for AXP803 DCDC5/6 Maxime Ripard
2017-10-04 11:29 ` Applied "regulator: axp20x: Fix poly-phase bit offset for AXP803 DCDC5/6" to the regulator tree Mark Brown
2017-09-29 3:25 ` [PATCH 2/7] regulator: axp20x: Add support for AXP813 regulators Chen-Yu Tsai
2017-09-29 8:33 ` Maxime Ripard
2017-10-04 10:50 ` Lee Jones
2017-10-04 11:29 ` Applied "regulator: axp20x: Add support for AXP813 regulators" to the regulator tree Mark Brown
2017-09-29 3:25 ` [PATCH 3/7] mfd: axp20x: Add axp20x-regulator cell for AXP813 Chen-Yu Tsai
2017-09-29 8:33 ` Maxime Ripard
2017-10-04 10:49 ` Lee Jones
2017-09-29 3:25 ` [PATCH 4/7] ARM: dts: sunxi: Add dtsi for AXP81x PMIC Chen-Yu Tsai
2017-09-29 8:32 ` Maxime Ripard
2017-09-29 8:41 ` Chen-Yu Tsai
2017-09-29 3:25 ` [PATCH 5/7] ARM: dts: sun8i: a83t: cubietruck-plus: Add AXP818 regulator nodes Chen-Yu Tsai
2017-10-02 16:24 ` Maxime Ripard
2017-10-03 2:14 ` Chen-Yu Tsai
2017-09-29 3:25 ` [PATCH 6/7] ARM: dts: sun8i: a83t: bananapi-m3: Add AXP813 " Chen-Yu Tsai
2017-09-29 3:25 ` [PATCH 7/7] ARM: dts: sun8i: a83t: allwinner-h8homlet-v2: Add AXP818 " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929032514.31727-2-wens@csie.org \
--to=wens@csie.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox