From mboxrd@z Thu Jan  1 00:00:00 1970
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
Date: Sat, 30 Sep 2017 08:07:10 +0200
Subject: [PATCH v2] mmc: sdhci-xenon: Fix clock resource by adding an
 optional bus clock
In-Reply-To: <20170930104109.60853202@xhacker.debian>
References: <20170929130435.6805-1-gregory.clement@free-electrons.com>
 <20170930104109.60853202@xhacker.debian>
Message-ID: <20170930080710.119c0258@windsurf>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hello,

On Sat, 30 Sep 2017 10:41:09 +0800, Jisheng Zhang wrote:

> > +	priv->axi_clk = devm_clk_get(&pdev->dev, "axi");
> > +	if (IS_ERR(priv->axi_clk)) {
> > +		err = PTR_ERR(priv->axi_clk);
> > +		if (err == -EPROBE_DEFER)
> > +			goto err_clk;
> > +		priv->axi_clk = NULL;  
> 
> IMHO, this assignment could be removed. What do you think?

No, because if the clock is not present in the Device Tree,
priv->axi_clk will contain an error code encoded as a pointer, so
priv->axi_clk will not be NULL. Hence the rest of the code that will
operate on this clock will believe there is a valid clock pointed by
priv->axi_clk. So we really want to reset it to NULL when there was an
error getting the clock.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com