From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Mon, 2 Oct 2017 09:14:34 +0200 Subject: [PATCH 20/22] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB In-Reply-To: References: <4503b50eac08f472e8690ec61f4d144e62cbdc55.1506678250.git.horms+renesas@verge.net.au> <29d4573f-4127-225c-1abc-7f341734d7d7@cogentembedded.com> Message-ID: <20171002071433.GA10579@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Oct 02, 2017 at 01:18:49AM +0000, Yoshihiro Shimoda wrote: > Hello, > > > -----Original Message----- > > From: Sergei Shtylyov > > Sent: Saturday, September 30, 2017 7:24 PM > > > > Hello! > > > > On 9/29/2017 2:52 PM, Simon Horman wrote: > > > > > From: Yoshihiro Shimoda > > > > > > This patch enables EthernetAVB for R-Car D3 draak board. > > > > > > Signed-off-by: Yoshihiro Shimoda > > > Reviewed-by: Geert Uytterhoeven > > > Signed-off-by: Simon Horman > > > --- > > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 +++++++++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > index 7b776cb7e928..96b7ff5cc321 100644 > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > [...] > > > @@ -37,6 +39,14 @@ > > > }; > > > > > > &pfc { > > > + avb0_pins: avb { > > > + mux { > > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > > ^^^^^^^^^^^^^^ > > Hum, I don't think it's compatible with routing the PHY interrupt via > > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT anyway. > > Oops! You're correct. I should drop "avb0_phy_int". > > Simon-san, may I send a follow-up patch to fix this? Thanks Sergei, thanks Shimoda-san, yes, please provide a follow-up patch. At this stage I don't think we need to re-spin this pull-request to fix this, rather a follow-up patch can be included in a follow-up pull request. > > Best regards, > Yoshihiro Shimoda > > > > + "avb0_mii"; > > > + function = "avb0"; > > > + }; > > > + }; > > > + > > > scif2_pins: scif2 { > > > groups = "scif2_data"; > > > function = "scif2"; > > > @@ -56,6 +66,21 @@ > > > status = "okay"; > > > }; > > > > > > +&avb { > > > + pinctrl-0 = <&avb0_pins>; > > > + pinctrl-names = "default"; > > > + renesas,no-ether-link; > > > + phy-handle = <&phy0>; > > > + status = "okay"; > > > + > > > + phy0: ethernet-phy at 0 { > > > + rxc-skew-ps = <1500>; > > > + reg = <0>; > > > + interrupt-parent = <&gpio5>; > > > + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; > > > + }; > > > +}; > > > + > > > &scif2 { > > > pinctrl-0 = <&scif2_pins>; > > > pinctrl-names = "default"; > > > > MBR, Sergei