* [PATCH] arm64: fix misleading data abort decoding
@ 2017-10-02 11:42 Mark Rutland
2017-10-02 12:02 ` Will Deacon
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Mark Rutland @ 2017-10-02 11:42 UTC (permalink / raw)
To: linux-arm-kernel
Currently data_abort_decode() dumps the ISS field as a decimal value
with a '0x' prefix, which is somewhat misleading.
Fix it to print as hexadecimal, as was intended.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Julien Thierry <julien.thierry@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Fixes: 1f9b8936f36f4a8e ("arm64: Decode information from ESR upon mem faults")
---
arch/arm64/mm/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
index 89993c4b..a6d5281 100644
--- a/arch/arm64/mm/fault.c
+++ b/arch/arm64/mm/fault.c
@@ -97,7 +97,7 @@ static void data_abort_decode(unsigned int esr)
(esr & ESR_ELx_SF) >> ESR_ELx_SF_SHIFT,
(esr & ESR_ELx_AR) >> ESR_ELx_AR_SHIFT);
} else {
- pr_alert(" ISV = 0, ISS = 0x%08lu\n", esr & ESR_ELx_ISS_MASK);
+ pr_alert(" ISV = 0, ISS = 0x%08lx\n", esr & ESR_ELx_ISS_MASK);
}
pr_alert(" CM = %lu, WnR = %lu\n",
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] arm64: fix misleading data abort decoding
2017-10-02 11:42 [PATCH] arm64: fix misleading data abort decoding Mark Rutland
@ 2017-10-02 12:02 ` Will Deacon
2017-10-02 12:17 ` Julien Thierry
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2017-10-02 12:02 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 02, 2017 at 12:42:00PM +0100, Mark Rutland wrote:
> Currently data_abort_decode() dumps the ISS field as a decimal value
> with a '0x' prefix, which is somewhat misleading.
>
> Fix it to print as hexadecimal, as was intended.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Julien Thierry <julien.thierry@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Fixes: 1f9b8936f36f4a8e ("arm64: Decode information from ESR upon mem faults")
> ---
> arch/arm64/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 89993c4b..a6d5281 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -97,7 +97,7 @@ static void data_abort_decode(unsigned int esr)
> (esr & ESR_ELx_SF) >> ESR_ELx_SF_SHIFT,
> (esr & ESR_ELx_AR) >> ESR_ELx_AR_SHIFT);
> } else {
> - pr_alert(" ISV = 0, ISS = 0x%08lu\n", esr & ESR_ELx_ISS_MASK);
> + pr_alert(" ISV = 0, ISS = 0x%08lx\n", esr & ESR_ELx_ISS_MASK);
> }
>
> pr_alert(" CM = %lu, WnR = %lu\n",
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: fix misleading data abort decoding
2017-10-02 11:42 [PATCH] arm64: fix misleading data abort decoding Mark Rutland
2017-10-02 12:02 ` Will Deacon
@ 2017-10-02 12:17 ` Julien Thierry
2017-10-02 12:54 ` Dave Martin
2017-10-02 14:06 ` Catalin Marinas
3 siblings, 0 replies; 5+ messages in thread
From: Julien Thierry @ 2017-10-02 12:17 UTC (permalink / raw)
To: linux-arm-kernel
On 02/10/17 12:42, Mark Rutland wrote:
> Currently data_abort_decode() dumps the ISS field as a decimal value
> with a '0x' prefix, which is somewhat misleading.
>
> Fix it to print as hexadecimal, as was intended.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Julien Thierry <julien.thierry@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Fixes: 1f9b8936f36f4a8e ("arm64: Decode information from ESR upon mem faults")
> ---
> arch/arm64/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 89993c4b..a6d5281 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -97,7 +97,7 @@ static void data_abort_decode(unsigned int esr)
> (esr & ESR_ELx_SF) >> ESR_ELx_SF_SHIFT,
> (esr & ESR_ELx_AR) >> ESR_ELx_AR_SHIFT);
> } else {
> - pr_alert(" ISV = 0, ISS = 0x%08lu\n", esr & ESR_ELx_ISS_MASK);
> + pr_alert(" ISV = 0, ISS = 0x%08lx\n", esr & ESR_ELx_ISS_MASK);
Whoops, thanks for catching that.
FWIW:
reviewed-by: Julien Thierry <julien.thierry@arm.com>
Thanks,
--
Julien Thierry
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: fix misleading data abort decoding
2017-10-02 11:42 [PATCH] arm64: fix misleading data abort decoding Mark Rutland
2017-10-02 12:02 ` Will Deacon
2017-10-02 12:17 ` Julien Thierry
@ 2017-10-02 12:54 ` Dave Martin
2017-10-02 14:06 ` Catalin Marinas
3 siblings, 0 replies; 5+ messages in thread
From: Dave Martin @ 2017-10-02 12:54 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 02, 2017 at 12:42:00PM +0100, Mark Rutland wrote:
> Currently data_abort_decode() dumps the ISS field as a decimal value
> with a '0x' prefix, which is somewhat misleading.
>
> Fix it to print as hexadecimal, as was intended.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Julien Thierry <julien.thierry@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Fixes: 1f9b8936f36f4a8e ("arm64: Decode information from ESR upon mem faults")
> ---
> arch/arm64/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 89993c4b..a6d5281 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -97,7 +97,7 @@ static void data_abort_decode(unsigned int esr)
> (esr & ESR_ELx_SF) >> ESR_ELx_SF_SHIFT,
> (esr & ESR_ELx_AR) >> ESR_ELx_AR_SHIFT);
> } else {
> - pr_alert(" ISV = 0, ISS = 0x%08lu\n", esr & ESR_ELx_ISS_MASK);
> + pr_alert(" ISV = 0, ISS = 0x%08lx\n", esr & ESR_ELx_ISS_MASK);
FWIW, since this is in front of me...
Reviewed-by: Dave Martin <Dave.Martin@arm.com>
(esr & ESR_ELx_ISS_MASK seems long somewhat by accident, but the
compiler should warn realiably if the type becomes mismatched in the
future -- this patch makes the situation no worse anyway)
Cheers
---Dave
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: fix misleading data abort decoding
2017-10-02 11:42 [PATCH] arm64: fix misleading data abort decoding Mark Rutland
` (2 preceding siblings ...)
2017-10-02 12:54 ` Dave Martin
@ 2017-10-02 14:06 ` Catalin Marinas
3 siblings, 0 replies; 5+ messages in thread
From: Catalin Marinas @ 2017-10-02 14:06 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 02, 2017 at 12:42:00PM +0100, Mark Rutland wrote:
> Currently data_abort_decode() dumps the ISS field as a decimal value
> with a '0x' prefix, which is somewhat misleading.
>
> Fix it to print as hexadecimal, as was intended.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Julien Thierry <julien.thierry@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Fixes: 1f9b8936f36f4a8e ("arm64: Decode information from ESR upon mem faults")
> ---
> arch/arm64/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Queued for 4.14-rc4. Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-02 14:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-02 11:42 [PATCH] arm64: fix misleading data abort decoding Mark Rutland
2017-10-02 12:02 ` Will Deacon
2017-10-02 12:17 ` Julien Thierry
2017-10-02 12:54 ` Dave Martin
2017-10-02 14:06 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).