From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 20/22] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB
Date: Tue, 3 Oct 2017 09:45:08 +0200 [thread overview]
Message-ID: <20171003074508.GA29129@verge.net.au> (raw)
In-Reply-To: <TY1PR06MB099289399914401B22232C67D87D0@TY1PR06MB0992.apcprd06.prod.outlook.com>
On Mon, Oct 02, 2017 at 09:16:56AM +0000, Yoshihiro Shimoda wrote:
> Hi Simon-san,
>
> > -----Original Message-----
> > From: Simon Horman
> > Sent: Monday, October 2, 2017 4:15 PM
> >
> > On Mon, Oct 02, 2017 at 01:18:49AM +0000, Yoshihiro Shimoda wrote:
> > > Hello,
> > >
> > > > -----Original Message-----
> > > > From: Sergei Shtylyov
> > > > Sent: Saturday, September 30, 2017 7:24 PM
> > > >
> > > > Hello!
> > > >
> > > > On 9/29/2017 2:52 PM, Simon Horman wrote:
> > > >
> > > > > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > > > >
> > > > > This patch enables EthernetAVB for R-Car D3 draak board.
> > > > >
> > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > > > ---
> > > > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 +++++++++++++++++++++++++
> > > > > 1 file changed, 25 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > > > index 7b776cb7e928..96b7ff5cc321 100644
> > > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > > [...]
> > > > > @@ -37,6 +39,14 @@
> > > > > };
> > > > >
> > > > > &pfc {
> > > > > + avb0_pins: avb {
> > > > > + mux {
> > > > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc",
> > > > ^^^^^^^^^^^^^^
> > > > Hum, I don't think it's compatible with routing the PHY interrupt via
> > > > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT anyway.
> > >
> > > Oops! You're correct. I should drop "avb0_phy_int".
> > >
> > > Simon-san, may I send a follow-up patch to fix this?
> >
> > Thanks Sergei, thanks Shimoda-san,
> >
> > yes, please provide a follow-up patch.
> >
> > At this stage I don't think we need to re-spin this pull-request
> > to fix this, rather a follow-up patch can be included
> > in a follow-up pull request.
>
> I got it. I will send it. Also, should I send salvator-common and ulcb patches
> about Geert-san's comment (These dtsi files also enable "avb_phy_int" for now)?
Hi Shimoda-san,
yes, I think that would be best.
Please include Fixes tags.
next prev parent reply other threads:[~2017-10-03 7:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 11:52 [GIT PULL] Renesas ARM64 Based SoC DT Updates for v4.15 Simon Horman
2017-09-29 11:52 ` [PATCH 01/22] arm64: dts: renesas: r8a7795-es1: Drop extra zero from usb unit address Simon Horman
2017-09-29 11:52 ` [PATCH 02/22] arm64: dts: renesas: r8a7796: Add FDP1 instance Simon Horman
2017-09-29 11:52 ` [PATCH 03/22] arm64: dts: renesas: r8a77995: update PFC node name to pin-controller Simon Horman
2017-09-29 11:52 ` [PATCH 04/22] arm64: dts: renesas: ulcb: Enable display output Simon Horman
2017-09-29 11:52 ` [PATCH 05/22] arm64: dts: renesas: r8a7795: Drop bogus HDMI node names suffixes Simon Horman
2017-09-29 11:52 ` [PATCH 06/22] arm64: renesas: Add Renesas R8A77970 Kconfig support Simon Horman
2017-09-29 11:52 ` [PATCH 07/22] arm64: dts: renesas: r8a77995: Use r8a7795-sysc binding definitions Simon Horman
2017-09-29 11:52 ` [PATCH 08/22] arm64: dts: renesas: r8a77995: Use r8a7795-cpg-mssr " Simon Horman
2017-09-29 11:52 ` [PATCH 09/22] arm64: dts: renesas: r8a77995: add GPIO device nodes Simon Horman
2017-09-29 11:52 ` [PATCH 10/22] arm64: dts: renesas: r8a77995: Add EthernetAVB device node Simon Horman
2017-09-29 11:52 ` [PATCH 11/22] arm64: dts: renesas: initial R8A77970 SoC device tree Simon Horman
2017-09-29 11:52 ` [PATCH 12/22] arm64: dts: renesas: r8a77970: add SYS-DMAC support Simon Horman
2017-09-29 11:52 ` [PATCH 13/22] arm64: dts: renesas: r8a77970: add [H]SCIF support Simon Horman
2017-09-29 11:52 ` [PATCH 14/22] arm64: dts: renesas: r8a77970: add EtherAVB support Simon Horman
2017-09-29 11:52 ` [PATCH 15/22] arm64: dts: draak: Add serial console pins Simon Horman
2017-09-29 11:52 ` [PATCH 16/22] arm64: dts: renesas: r8a77995: Add USB2.0 PHY device node Simon Horman
2017-09-29 11:52 ` [PATCH 17/22] arm64: dts: renesas: r8a77995: add USB2.0 Host (EHCI/OHCI) " Simon Horman
2017-09-29 11:52 ` [PATCH 18/22] arm64: dts: renesas: r8a77995: draak: enable USB2.0 PHY Simon Horman
2017-09-29 11:52 ` [PATCH 19/22] arm64: dts: renesas: r8a77995: draak: enable USB2.0 Host (EHCI/OHCI) Simon Horman
2017-09-29 11:52 ` [PATCH 20/22] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB Simon Horman
2017-09-30 10:24 ` Sergei Shtylyov
2017-10-02 1:18 ` Yoshihiro Shimoda
2017-10-02 7:14 ` Simon Horman
2017-10-02 9:16 ` Yoshihiro Shimoda
2017-10-03 7:45 ` Simon Horman [this message]
2017-10-02 7:21 ` Geert Uytterhoeven
2017-09-29 11:52 ` [PATCH 21/22] arm64: dts: renesas: r8a7795: add USB3.0 peripheral device node Simon Horman
2017-09-29 11:52 ` [PATCH 22/22] arm64: dts: renesas: r8a7796: " Simon Horman
2017-10-19 21:39 ` [GIT PULL] Renesas ARM64 Based SoC DT Updates for v4.15 Arnd Bergmann
2017-10-20 9:03 ` Simon Horman
2017-10-20 9:06 ` Arnd Bergmann
2017-10-20 9:28 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003074508.GA29129@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).