From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] cpufreq: imx6q: Move speed grading check to cpufreq driver
Date: Wed, 4 Oct 2017 11:43:28 +0530 [thread overview]
Message-ID: <20171004061328.GC8478@vireshk-i7> (raw)
In-Reply-To: <1506784606-2064-1-git-send-email-festevam@gmail.com>
On 30-09-17, 12:16, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> On some i.MX6 SoCs (like i.MX6SL, i.MX6SX and i.MX6UL) that do not have
> speed grading check, opp table will not be created in platform code,
> so cpufreq driver prints the following error message:
>
> cpu cpu0: dev_pm_opp_get_opp_count: OPP table not found (-19)
>
> However, this is not really an error in this case because the
> imx6q-cpufreq driver first calls dev_pm_opp_get_opp_count()
> and if it fails, it means that platform code does not provide
> OPP and then dev_pm_opp_of_add_table() will be called.
>
> In order to avoid such confusing error message, move the speed grading
> check from platform code to the imx6q-cpufreq driver.
>
> This way the imx6q-cpufreq no longer has to check whether OPP table
> is supplied by platform code.
>
> Tested on a i.MX6Q and i.MX6UL based boards.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Previous discussion on this topic:
> https://patchwork.kernel.org/patch/9295059/
>
> Changes since v2:
> - Fixed a typo in the commit log (missed SL) - Otavio
> - Remove __init anotation from imx6q_opp_check_speed_grading()
> Changes since v1:
> - Remove unneeded has_speed_grading() function.
Looks fine to me.
@Shawn: Can you please let us know if you are fine with it?
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2017-10-04 6:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 15:16 [PATCH v3] cpufreq: imx6q: Move speed grading check to cpufreq driver Fabio Estevam
2017-10-04 6:13 ` Viresh Kumar [this message]
2017-10-13 6:51 ` Shawn Guo
2017-10-15 15:42 ` Fabio Estevam
2017-10-16 0:13 ` Rafael J. Wysocki
2017-10-16 10:46 ` Fabio Estevam
2017-10-18 2:09 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004061328.GC8478@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox