From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: mm: Clarify a printk in data_abort_decode()
Date: Thu, 5 Oct 2017 14:04:36 +0100 [thread overview]
Message-ID: <20171005130436.GB5235@leverpostej> (raw)
In-Reply-To: <20171005125914.34uc5qq5titpq6zi@mwanda>
Hi,
On Thu, Oct 05, 2017 at 03:59:14PM +0300, Dan Carpenter wrote:
> The 0x in front of a base 10 number is misleading so I removed it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 89993c4be1be..a5382e90418c 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -97,7 +97,7 @@ static void data_abort_decode(unsigned int esr)
> (esr & ESR_ELx_SF) >> ESR_ELx_SF_SHIFT,
> (esr & ESR_ELx_AR) >> ESR_ELx_AR_SHIFT);
> } else {
> - pr_alert(" ISV = 0, ISS = 0x%08lu\n", esr & ESR_ELx_ISS_MASK);
> + pr_alert(" ISV = 0, ISS = %08lu\n", esr & ESR_ELx_ISS_MASK);
A fix has already been queued [0,1], ensuring this is printed as hex.
Catalin, I see that hasn't been pushed out to the arm64 fixes/core
branch. Is that deliberate?
Thanks,
Mark.
[0] https://lkml.kernel.org/r/1506944520-21998-1-git-send-email-mark.rutland at arm.com
[1] https://lkml.kernel.org/r/20171002140632.alqo4u5dn5uenjt7 at armageddon.cambridge.arm.com
next prev parent reply other threads:[~2017-10-05 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 12:59 [PATCH] arm64: mm: Clarify a printk in data_abort_decode() Dan Carpenter
2017-10-05 13:04 ` Mark Rutland [this message]
2017-10-05 13:22 ` Dan Carpenter
2017-10-05 13:29 ` Mark Rutland
2017-10-05 15:05 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005130436.GB5235@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox