From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 11/11] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes
Date: Thu, 5 Oct 2017 17:09:27 -0500 [thread overview]
Message-ID: <20171005220927.7rabn3ftvow253xj@rob-hp-laptop> (raw)
In-Reply-To: <c8697b60-294f-7cc1-8425-aa5b837fcca0@gmail.com>
On Wed, Sep 27, 2017 at 09:50:46PM -0700, Florian Fainelli wrote:
>
>
> On 09/27/2017 07:12 AM, Andrew Lunn wrote:
> > On Wed, Sep 27, 2017 at 09:34:14AM +0200, Corentin Labbe wrote:
> >> Each child node of an MDIO node is scanned as a PHY when calling
> >> of_mdiobus_register() givint the following result:
> >> [ 18.175379] mdio_bus stmmac-0: /soc/ethernet at 1c30000/mdio/mdio-mux has invalid PHY address
> >> [ 18.175408] mdio_bus stmmac-0: scan phy mdio-mux at address 0
> >> [ 18.175450] mdio_bus stmmac-0: scan phy mdio-mux at address 1
> >> [...]
> >> [ 18.176420] mdio_bus stmmac-0: scan phy mdio-mux at address 30
> >> [ 18.176452] mdio_bus stmmac-0: scan phy mdio-mux at address 31
> >>
> >> Since mdio-mux nodes are not PHY, this patch a way to to not scan
> >> them.
> >
> > Hi Corentin
> >
> > I still don't like this, but ...
>
> Me neither, even more so as I don't understand the reasoning behind
> putting the mux as a child node of the MDIO bus controller in the first
> place.
If no one agrees with me, then you shouldn't just accept my answers. I'm
not always right.
Looking at this some more, why can't mdio-mux-mmio be used? Then there
is nothing to review or discuss. If you want to extend that then make it
clear this is just extending/inheriting already defined bindings.
That being said, if we were starting over I would probably do mux
designs differently with DT hierarchy reflecting the mux hierarchy, but
that ship has sailed.
Rob
next prev parent reply other threads:[~2017-10-05 22:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 7:34 [PATCH v6 00/11] net: stmmac: dwmac-sun8i: Handle integrated PHY Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 01/11] dt-bindings: net: Restore sun8i dwmac binding Corentin Labbe
2017-10-05 20:59 ` Rob Herring
2017-09-27 7:34 ` [PATCH v6 02/11] arm: dts: sunxi: Restore EMAC changes Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 03/11] arm64: dts: allwinner: " Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 04/11] net: stmmac: sun8i: Restore the compatibles Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY Corentin Labbe
2017-09-27 10:15 ` Maxime Ripard
2017-09-27 14:02 ` Andrew Lunn
2017-09-28 7:37 ` Corentin Labbe
2017-10-04 19:00 ` Corentin Labbe
2017-10-08 18:33 ` Corentin Labbe
2017-10-09 21:08 ` Maxime Ripard
2017-09-28 4:53 ` Florian Fainelli
2017-09-28 7:07 ` Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 06/11] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac Corentin Labbe
2017-09-27 10:16 ` Maxime Ripard
2017-09-27 13:47 ` Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 07/11] arm64: dts: allwinner: add snps, dwmac-mdio compatible to emac/mdio Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 08/11] net: stmmac: snps, dwmac-mdio MDIOs are automatically registered Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 09/11] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 10/11] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 11/11] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes Corentin Labbe
2017-09-27 14:12 ` Andrew Lunn
2017-09-28 4:50 ` Florian Fainelli
2017-10-05 22:09 ` Rob Herring [this message]
2017-10-05 22:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005220927.7rabn3ftvow253xj@rob-hp-laptop \
--to=robh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox