From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Fri, 6 Oct 2017 11:27:57 +0200 Subject: [PATCH 13/20] ARM: dts: sun4i: Remove gpio-keys warnings In-Reply-To: References: <247d527cb833713f487b97a2c95e30545273ac92.1507198895.git-series.maxime.ripard@free-electrons.com> Message-ID: <20171006092757.eexffejnralxlguf@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Oct 05, 2017 at 03:51:02PM +0000, Chen-Yu Tsai wrote: > On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard > wrote: > > Some gpio-keys definitions in our DTs were having buttons defined with a > > unit-address and that would generate a DTC warning. > > > > Change the buttons node names to remove the warnings. > > > > Signed-off-by: Maxime Ripard > > --- > > arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 40 ++++++++++----------- > > arch/arm/boot/dts/sun4i-a10-pcduino.dts | 6 +-- > > 2 files changed, 23 insertions(+), 23 deletions(-) > > > > diff --git a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts b/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts > > index 7c7f12132ea3..13224f5ac166 100644 > > --- a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts > > +++ b/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts > > @@ -67,7 +67,7 @@ > > #size-cells = <0>; > > poll-interval = <20>; > > > > - button at 0 { > > + left-joystick-left { > > Does this fit the naming scheme? Should we have "-button" suffices? The example binding of gpio-keys just have the key name as node name, just like most of the DT out there I could find. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: