linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ARM: sun8i: r40: add USB host port nodes for R40
Date: Mon, 9 Oct 2017 23:03:40 +0200	[thread overview]
Message-ID: <20171009210340.ak6wo3vqnwj4gom4@flea.home> (raw)
In-Reply-To: <20171008042906.46779-3-icenowy@aosc.io>

On Sun, Oct 08, 2017 at 04:29:02AM +0000, Icenowy Zheng wrote:
> From: Icenowy Zheng <icenowy@aosc.xyz>
> 
> Allwinner R40 SoC features a USB OTG port and two USB HOST ports.
> 
> Add support for the host ports in the DTSI file.
> 
> The OTG controller still cannot work with existing compatibles, and needs
> more investigation. So it's not added yet.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
>  arch/arm/boot/dts/sun8i-r40.dtsi | 78 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
> index d5a6745409ae..f6c917cbbaac 100644
> --- a/arch/arm/boot/dts/sun8i-r40.dtsi
> +++ b/arch/arm/boot/dts/sun8i-r40.dtsi
> @@ -173,6 +173,84 @@
>  			#size-cells = <0>;
>  		};
>  
> +		usbphy: phy at 1c13400 {
> +			compatible = "allwinner,sun8i-r40-usb-phy";
> +			reg = <0x01c13400 0x14>,
> +			      <0x01c14800 0x4>,
> +			      <0x01c19800 0x4>,
> +			      <0x01c1c800 0x4>;
> +			reg-names = "phy_ctrl",
> +				    "pmu0",
> +				    "pmu1",
> +				    "pmu2";
> +			clocks = <&ccu CLK_USB_PHY0>,
> +				 <&ccu CLK_USB_PHY1>,
> +				 <&ccu CLK_USB_PHY2>;
> +			clock-names = "usb0_phy",
> +				      "usb1_phy",
> +				      "usb2_phy";
> +			resets = <&ccu RST_USB_PHY0>,
> +				 <&ccu RST_USB_PHY1>,
> +				 <&ccu RST_USB_PHY2>;
> +			reset-names = "usb0_reset",
> +				      "usb1_reset",
> +				      "usb2_reset";
> +			status = "disabled";
> +			#phy-cells = <1>;
> +		};
> +
> +		ehci1: usb at 1c19000 {
> +			compatible = "allwinner,sun8i-r40-ehci", "generic-ehci";
> +			reg = <0x01c19000 0x100>;

What is the actual size here?

> +			interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&ccu CLK_BUS_OHCI1>,
> +				 <&ccu CLK_BUS_EHCI1>,
> +				 <&ccu CLK_USB_OHCI1>;
> +			resets = <&ccu RST_BUS_OHCI1>,
> +				 <&ccu RST_BUS_EHCI1>;

Why do you need to take the OHCI resources too?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171009/2ae2132e/attachment.sig>

  reply	other threads:[~2017-10-09 21:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-08  4:29 [PATCH 0/6] Allwinner R40 USB host support Icenowy Zheng
2017-10-08  4:29 ` [PATCH 1/6] phy: sun4i-usb: add support for R40 USB PHY Icenowy Zheng
2017-10-09 20:58   ` Maxime Ripard
2017-10-18 11:39     ` Kishon Vijay Abraham I
2017-10-18 11:42       ` Maxime Ripard
2017-10-18 11:46         ` Kishon Vijay Abraham I
2017-12-30 11:38           ` Icenowy Zheng
2018-01-03  8:40             ` Kishon Vijay Abraham I
2017-10-13 19:29   ` Rob Herring
2017-10-08  4:29 ` [PATCH 2/6] ARM: sun8i: r40: add USB host port nodes for R40 Icenowy Zheng
2017-10-09 21:03   ` Maxime Ripard [this message]
2017-10-09 23:24     ` Icenowy Zheng
2017-10-16  9:32       ` Maxime Ripard
2017-10-16  9:39         ` icenowy at aosc.io
2017-10-16 12:06           ` Maxime Ripard
2017-10-18 12:21             ` icenowy at aosc.io
2017-10-08  4:29 ` [PATCH 3/6] ARM: sun8i: r40: add 5V regulator for Banana Pi M2 Ultra Icenowy Zheng
2017-10-09 21:04   ` Maxime Ripard
2017-10-09 23:25     ` Icenowy Zheng
2017-10-10  2:25       ` [linux-sunxi] " Chen-Yu Tsai
2017-10-10  9:39         ` Maxime Ripard
2017-10-08  4:29 ` [PATCH 4/6] ARM: sun8i: v40: add 5V regulator for Banana Pi M2 Berry Icenowy Zheng
2017-10-08  4:29 ` [PATCH 5/6] ARM: sun8i: r40: enable USB host for Banana Pi M2 Ultra Icenowy Zheng
2017-10-08  4:29 ` [PATCH 6/6] ARM: sun8i: v40: enable USB host ports for Banana Pi M2 Berry Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171009210340.ak6wo3vqnwj4gom4@flea.home \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).