From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events
Date: Wed, 11 Oct 2017 14:55:17 +0100 [thread overview]
Message-ID: <20171011135517.GF11106@arm.com> (raw)
In-Reply-To: <20171011132431.GL17961@rric.localdomain>
On Wed, Oct 11, 2017 at 03:24:31PM +0200, Robert Richter wrote:
> On 11.10.17 13:19:27, Will Deacon wrote:
> > On Tue, Aug 29, 2017 at 02:47:30PM +0200, Robert Richter wrote:
> > > Shaokun,
> > >
> > > On 29.08.17 17:26:00, Zhangshaokun wrote:
> > > > On 2017/8/24 20:03, Ganapatrao Kulkarni wrote:
> > > > > This is not a full event list, but a short list of useful events.
> > > > >
> > > > > Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> > > > > ---
> > > > > tools/perf/pmu-events/arch/arm64/mapfile.csv | 15 ++++++
> > > > > .../arm64/thunderx2/implementation-defined.json | 62 ++++++++++++++++++++++
> > > > > 2 files changed, 77 insertions(+)
> > > > > create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv
> > > > > create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json
> > > > >
> > > >
> > > > I saw you also used thunderx2 in tools/perf/pmu-events/arch/arm64/, how about John's suggestion
> > > > that would use vendor sub-folder?
> > > > Of course, appreciate maintainer's comments.
> > >
> > > this would just add another level of subdirectories. I rather would
> > > prefer to have a per platform dir comparable to what is listed in
> > >
> > > arch/arm64/Kconfig.platforms
> > >
> > > This is the same as Ganapat has implemented it.
> >
> > FWIW, I agree with Zhangshaokun here that a silicon vendor subdirectory
> > would organise things better. It also matches what we do for
> > arch/arm64/boot/dts/
>
> A file structure like:
>
> tools/perf/pmu-events/arch/arm64/cavium/thunderx2/implementation-defined.json
>
> looks quite horible. In contrast to dts dir we will need another
> subdir for each platform and will then have two levels of subdirs.
In which case, call the file thunderx2-imp-def.json or something. The
advantage then is that the SoC names are namespaced by vendor, which is
the best way to avoid confusion imo.
Will
next prev parent reply other threads:[~2017-10-11 13:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 12:03 [PATCH v6 0/4] Add support for ThunderX2 pmu events using json files Ganapatrao Kulkarni
2017-08-24 12:03 ` [PATCH v6 1/4] perf utils: passing pmu as a parameter to function get_cpuid_str Ganapatrao Kulkarni
2017-08-24 12:03 ` [PATCH v6 2/4] perf tools arm64: Add support for get_cpuid_str function Ganapatrao Kulkarni
2017-10-11 12:13 ` Will Deacon
2017-10-12 5:15 ` Ganapatrao Kulkarni
2017-08-24 12:03 ` [PATCH v6 3/4] perf utils: Add helper function is_pmu_core to detect PMU CORE devices Ganapatrao Kulkarni
2017-10-11 12:17 ` Will Deacon
2017-08-24 12:03 ` [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events Ganapatrao Kulkarni
2017-08-29 9:26 ` Zhangshaokun
2017-08-29 12:47 ` Robert Richter
2017-08-30 3:15 ` Zhangshaokun
2017-08-31 10:29 ` Zhangshaokun
2017-08-31 10:53 ` Robert Richter
2017-10-11 12:19 ` Will Deacon
2017-10-11 13:24 ` Robert Richter
2017-10-11 13:55 ` Will Deacon [this message]
2017-10-12 4:56 ` Ganapatrao Kulkarni
2017-09-20 8:45 ` [PATCH v6 0/4] Add support for ThunderX2 pmu events using json files Ganapatrao Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011135517.GF11106@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).