linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file
@ 2017-09-25 18:55 Marco Franchi
  2017-09-25 18:55 ` [PATCH 2/4] ARM: imx: 3ds-debugboard: Include "3ds_debugboard.h" " Marco Franchi
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Marco Franchi @ 2017-09-25 18:55 UTC (permalink / raw)
  To: linux-arm-kernel

The following build warnings are seen with W=1:

warning: no previous prototype for ?mx31moboard_devboard_init? 
[-Wmissing-prototypes] void __init mx31moboard_devboard_init(void)
warning: no previous prototype for ?mx31moboard_marxbot_init? 
[-Wmissing-prototypes] void __init mx31moboard_marxbot_init(void)

Fix these warnings by including "board-mx31moboard.h".

Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
---
 arch/arm/mach-imx/mx31moboard-devboard.c | 1 +
 arch/arm/mach-imx/mx31moboard-marxbot.c  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm/mach-imx/mx31moboard-devboard.c b/arch/arm/mach-imx/mx31moboard-devboard.c
index 1e91a09..3c224f4 100644
--- a/arch/arm/mach-imx/mx31moboard-devboard.c
+++ b/arch/arm/mach-imx/mx31moboard-devboard.c
@@ -22,6 +22,7 @@
 
 #include <linux/usb/otg.h>
 
+#include "board-mx31moboard.h"
 #include "common.h"
 #include "devices-imx31.h"
 #include "ehci.h"
diff --git a/arch/arm/mach-imx/mx31moboard-marxbot.c b/arch/arm/mach-imx/mx31moboard-marxbot.c
index 922d491..9a5a869 100644
--- a/arch/arm/mach-imx/mx31moboard-marxbot.c
+++ b/arch/arm/mach-imx/mx31moboard-marxbot.c
@@ -24,6 +24,7 @@
 
 #include <linux/usb/otg.h>
 
+#include "board-mx31moboard.h"
 #include "common.h"
 #include "devices-imx31.h"
 #include "ehci.h"
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/4] ARM: imx: 3ds-debugboard: Include "3ds_debugboard.h" header file
  2017-09-25 18:55 [PATCH 1/4] ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file Marco Franchi
@ 2017-09-25 18:55 ` Marco Franchi
  2017-09-25 18:55 ` [PATCH 3/4] ARM: imx: cpuidle-imx5: Include "cpuidle.h" " Marco Franchi
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Marco Franchi @ 2017-09-25 18:55 UTC (permalink / raw)
  To: linux-arm-kernel

The following build warning is seen with W=1:

warning: no previous prototype for ?mxc_expio_init? 
[-Wmissing-prototypes] int __init mxc_expio_init(u32 base, u32 intr_gpio)

Fix this warning by including "3ds_debugboard.h".

Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
---
 arch/arm/mach-imx/3ds_debugboard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/3ds_debugboard.c b/arch/arm/mach-imx/3ds_debugboard.c
index cda330c..0015abe 100644
--- a/arch/arm/mach-imx/3ds_debugboard.c
+++ b/arch/arm/mach-imx/3ds_debugboard.c
@@ -20,7 +20,7 @@
 #include <linux/smsc911x.h>
 #include <linux/regulator/machine.h>
 #include <linux/regulator/fixed.h>
-
+#include "3ds_debugboard.h"
 #include "hardware.h"
 
 /* LAN9217 ethernet base address */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/4] ARM: imx: cpuidle-imx5: Include "cpuidle.h" header file
  2017-09-25 18:55 [PATCH 1/4] ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file Marco Franchi
  2017-09-25 18:55 ` [PATCH 2/4] ARM: imx: 3ds-debugboard: Include "3ds_debugboard.h" " Marco Franchi
@ 2017-09-25 18:55 ` Marco Franchi
  2017-09-25 18:55 ` [PATCH 4/4] ARM: imx: mach-mx31lite: Make mx31lite_map_io static Marco Franchi
  2017-10-13  6:46 ` [PATCH 1/4] ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Marco Franchi @ 2017-09-25 18:55 UTC (permalink / raw)
  To: linux-arm-kernel

The following build warning is seen with W=1:

warning: no previous prototype for ?imx5_cpuidle_init? 
[-Wmissing-prototypes] int __init imx5_cpuidle_init(void)

Fix this warning by including "cpuidle.h".

Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
---
 arch/arm/mach-imx/cpuidle-imx5.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-imx/cpuidle-imx5.c b/arch/arm/mach-imx/cpuidle-imx5.c
index 3feca52..db01276 100644
--- a/arch/arm/mach-imx/cpuidle-imx5.c
+++ b/arch/arm/mach-imx/cpuidle-imx5.c
@@ -9,6 +9,7 @@
 #include <linux/cpuidle.h>
 #include <linux/module.h>
 #include <asm/system_misc.h>
+#include "cpuidle.h"
 
 static int imx5_cpuidle_enter(struct cpuidle_device *dev,
 			      struct cpuidle_driver *drv, int index)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 4/4] ARM: imx: mach-mx31lite: Make mx31lite_map_io static
  2017-09-25 18:55 [PATCH 1/4] ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file Marco Franchi
  2017-09-25 18:55 ` [PATCH 2/4] ARM: imx: 3ds-debugboard: Include "3ds_debugboard.h" " Marco Franchi
  2017-09-25 18:55 ` [PATCH 3/4] ARM: imx: cpuidle-imx5: Include "cpuidle.h" " Marco Franchi
@ 2017-09-25 18:55 ` Marco Franchi
  2017-10-13  6:46 ` [PATCH 1/4] ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Marco Franchi @ 2017-09-25 18:55 UTC (permalink / raw)
  To: linux-arm-kernel

The following build warning is seen with W=1:

warning: no previous prototype for ?mx31lite_map_io? 
[-Wmissing-prototypes] void __init mx31lite_map_io(void)

This function is only used in this file so make it "static".

Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
---
 arch/arm/mach-imx/mach-mx31lite.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/mach-mx31lite.c b/arch/arm/mach-imx/mach-mx31lite.c
index f033a57..a3250bc 100644
--- a/arch/arm/mach-imx/mach-mx31lite.c
+++ b/arch/arm/mach-imx/mach-mx31lite.c
@@ -245,7 +245,7 @@ static struct map_desc mx31lite_io_desc[] __initdata = {
 /*
  * Set up static virtual mappings.
  */
-void __init mx31lite_map_io(void)
+static void __init mx31lite_map_io(void)
 {
 	mx31_map_io();
 	iotable_init(mx31lite_io_desc, ARRAY_SIZE(mx31lite_io_desc));
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 1/4] ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file
  2017-09-25 18:55 [PATCH 1/4] ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file Marco Franchi
                   ` (2 preceding siblings ...)
  2017-09-25 18:55 ` [PATCH 4/4] ARM: imx: mach-mx31lite: Make mx31lite_map_io static Marco Franchi
@ 2017-10-13  6:46 ` Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2017-10-13  6:46 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 25, 2017 at 03:55:56PM -0300, Marco Franchi wrote:
> The following build warnings are seen with W=1:
> 
> warning: no previous prototype for ?mx31moboard_devboard_init? 
> [-Wmissing-prototypes] void __init mx31moboard_devboard_init(void)
> warning: no previous prototype for ?mx31moboard_marxbot_init? 
> [-Wmissing-prototypes] void __init mx31moboard_marxbot_init(void)
> 
> Fix these warnings by including "board-mx31moboard.h".
> 
> Signed-off-by: Marco Franchi <marco.franchi@nxp.com>

Applied all, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-10-13  6:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-25 18:55 [PATCH 1/4] ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file Marco Franchi
2017-09-25 18:55 ` [PATCH 2/4] ARM: imx: 3ds-debugboard: Include "3ds_debugboard.h" " Marco Franchi
2017-09-25 18:55 ` [PATCH 3/4] ARM: imx: cpuidle-imx5: Include "cpuidle.h" " Marco Franchi
2017-09-25 18:55 ` [PATCH 4/4] ARM: imx: mach-mx31lite: Make mx31lite_map_io static Marco Franchi
2017-10-13  6:46 ` [PATCH 1/4] ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).