* [PATCH -next] ARM: OMAP2+: omap_device: fix error return code in omap_device_copy_resources()
@ 2017-10-13 9:29 Wei Yongjun
2017-10-13 17:08 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-10-13 9:29 UTC (permalink / raw)
To: linux-arm-kernel
Fix to return error code -EINVAL from the irq_of_parse_and_map() error
handling case instead of 0, as done elsewhere in this function.
Fixes: d85a2d61432a ("ARM: OMAP2+: Populate legacy resources for dma
and smartreflex")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
arch/arm/mach-omap2/omap_device.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
index 713fc6b..d45cbfd 100644
--- a/arch/arm/mach-omap2/omap_device.c
+++ b/arch/arm/mach-omap2/omap_device.c
@@ -433,8 +433,10 @@ void omap_device_delete(struct omap_device *od)
irq = irq_of_parse_and_map(child, 0);
if (!irq)
irq = irq_of_parse_and_map(np, 0);
- if (!irq)
+ if (!irq) {
+ error = -EINVAL;
goto free;
+ }
/* Legacy DMA code needs interrupt name to be "0" */
res[1].start = irq;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH -next] ARM: OMAP2+: omap_device: fix error return code in omap_device_copy_resources()
2017-10-13 9:29 [PATCH -next] ARM: OMAP2+: omap_device: fix error return code in omap_device_copy_resources() Wei Yongjun
@ 2017-10-13 17:08 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2017-10-13 17:08 UTC (permalink / raw)
To: linux-arm-kernel
* Wei Yongjun <weiyongjun1@huawei.com> [171013 02:26]:
> Fix to return error code -EINVAL from the irq_of_parse_and_map() error
> handling case instead of 0, as done elsewhere in this function.
Thanks applying into omap-for-v4.15/ti-sysc.
Regards,
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-13 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-13 9:29 [PATCH -next] ARM: OMAP2+: omap_device: fix error return code in omap_device_copy_resources() Wei Yongjun
2017-10-13 17:08 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).