From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/13] mmc: dt-bindings: make compatible explicit
Date: Fri, 13 Oct 2017 15:09:43 -0500 [thread overview]
Message-ID: <20171013200943.qjyyjxuo54b4jgnu@rob-hp-laptop> (raw)
In-Reply-To: <CAPDyKFpzuctUJ7FB9thMi0h602iJZc=kbs7iaVb+0oNCC4K4ng@mail.gmail.com>
On Tue, Oct 10, 2017 at 09:19:14AM +0200, Ulf Hansson wrote:
> On 10 October 2017 at 03:37, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> > On Mon, 2017-10-09 at 16:54 +0200, Matthias Brugger wrote:
> >>
> >> On 10/09/2017 01:35 PM, Chaotian Jing wrote:
> >> > the driver has updated to have an explicit compatible, so update
> >> > binding file according to the driver change.
> >> >
> >> > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
> >> > ---
> >> > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++--
> >> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> >> > index 3e0a97c..2bb585b 100644
> >> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> >> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> >> > @@ -8,8 +8,8 @@ and the properties used by the msdc driver.
> >> >
> >> > Required properties:
> >> > - compatible: value should be either of the following.
> >> > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
> >> > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173
> >> > + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
> >> > + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
> >>
> >> You can merge this with patch 1.
> >
> > OK, will merge it in next patch.
>
> No, please don't!
>
> I would like DT documentation changes to be posted in separate
> patches. Moreover, those should be before driver changes, when you
> order the changes in your series.
>
> In this way, the bindings can be reviewed and acked separately, which
> makes it more convenient.
Yes. Also, it is step 2 in
Documentation/devicetree/bindings/submitting-patches.txt.
Rob
next prev parent reply other threads:[~2017-10-13 20:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 11:35 [PATCH v2 00/13] mmc: mediatek: add support of mt2701/mt2712 Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 01/13] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings Chaotian Jing
2017-10-09 14:53 ` Matthias Brugger
2017-10-09 11:35 ` [PATCH v2 02/13] mmc: mediatek: add support of mt2701/mt2712 Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 03/13] mmc: dt-bindings: make compatible explicit Chaotian Jing
2017-10-09 14:54 ` Matthias Brugger
2017-10-10 1:37 ` Chaotian Jing
2017-10-10 7:19 ` Ulf Hansson
2017-10-10 8:35 ` Matthias Brugger
2017-10-13 20:09 ` Rob Herring [this message]
2017-10-13 20:14 ` Rob Herring
2017-10-14 2:11 ` Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 04/13] arm64: dts: mt8173: remove "mediatek, mt8135-mmc" from mmc nodes Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 05/13] mmc: mediatek: make hs400_tune_response only for mt8173 Chaotian Jing
2017-10-09 14:58 ` Matthias Brugger
2017-10-10 1:39 ` Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 06/13] mmc: mediatek: add pad_tune0 support Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 07/13] mmc: mediatek: add async fifo and data tune support Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 08/13] mmc: mediatek: add busy_check support Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 09/13] mmc: mediatek: add stop_clk fix and enhance_rx support Chaotian Jing
2017-10-09 15:00 ` Matthias Brugger
2017-10-10 1:39 ` Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 10/13] mmc: mediatek: add support of source_cg clock Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 11/13] mmc: mediatek: add latch-ck support Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 12/13] mmc: mediatek: improve eMMC hs400 mode read performance Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 13/13] mmc: mediatek: perfer to use rise edge latching for cmd line Chaotian Jing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013200943.qjyyjxuo54b4jgnu@rob-hp-laptop \
--to=robh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox