From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: pxa: move header file out of deprecated i2c folder
Date: Fri, 13 Oct 2017 23:45:04 +0200 [thread overview]
Message-ID: <20171013214504.ugu5nquhv7dbg2kr@ninjato> (raw)
In-Reply-To: <87d15qlq6z.fsf@belgarion.home>
Hi Robert,
> I'm sorry I completely missed this one.
No worries, that happens.
> Either it's too late and trash this mail, or it's not, and then I'd suggest
> another approach :
> - patch 1 : move include/linux/i2c/pxa-i2c.h to include/platform_data/i2c-pxa.h
> (i2c-pxa.h and not pxa-i2c.h to be consistent)
> - patch 2 : move this chunk to arch/arm/mach-pxa/devices.h
> > extern void pxa_set_i2c_info(struct i2c_pxa_platform_data *info);
> >
> > #ifdef CONFIG_PXA27x
> > extern void pxa27x_set_i2c_power_info(struct i2c_pxa_platform_data *info);
> > #endif
> >
> > #ifdef CONFIG_PXA3xx
> > extern void pxa3xx_set_i2c_power_info(struct i2c_pxa_platform_data *info);
> > #endif
>
> This is the cleanest approach I could think of.
OK, will resend with your suggestions somewhen soon.
Thanks,
Wolfram
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171013/86896f5e/attachment.sig>
next prev parent reply other threads:[~2017-10-13 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 16:43 [PATCH] i2c: pxa: move header file out of deprecated i2c folder Wolfram Sang
2017-10-13 20:59 ` Robert Jarzmik
2017-10-13 21:45 ` Wolfram Sang [this message]
2017-10-29 17:52 ` Wolfram Sang
2017-10-29 20:34 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013214504.ugu5nquhv7dbg2kr@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox