linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property
@ 2017-10-16 22:34 Fabio Estevam
  2017-10-16 22:34 ` [PATCH 2/4] ARM: dts: imx6sx-softing-vining-2000: Fix the 'interrupt-parent' property Fabio Estevam
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Fabio Estevam @ 2017-10-16 22:34 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@nxp.com>

The 'interrupts' property has an extra cell by mistake.

Fix this, so that the following build warning is gone:

 DTC     arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
arch/arm/boot/dts/imx6ul-pico-hobbit.dtb: Warning (interrupts_property): interrupts size is (12), expected multiple of 8 in /soc/aips-bus at 2000000/ethernet at 20b4000/mdio/ethernet-phy at 1

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx6ul-pico-hobbit.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6ul-pico-hobbit.dts b/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
index 7d7254b..de54c70 100644
--- a/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
+++ b/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
@@ -175,7 +175,7 @@
 			reg = <1>;
 			max-speed = <100>;
 			interrupt-parent = <&gpio5>;
-			interrupts = <6 IRQ_TYPE_LEVEL_LOW 0>;
+			interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
 		};
 	};
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/4] ARM: dts: imx6sx-softing-vining-2000: Fix the 'interrupt-parent' property
  2017-10-16 22:34 [PATCH 1/4] ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property Fabio Estevam
@ 2017-10-16 22:34 ` Fabio Estevam
  2017-10-16 22:34 ` [PATCH 3/4] ARM: dts: imx35-eukrea-mbimxsd35-baseboard: Fix the 'cd-gpios' property Fabio Estevam
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2017-10-16 22:34 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@nxp.com>

The correct property name is 'interrupt-parent', so fix it accordingly.

This fixes the following build warning:

arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /soc/aips-bus at 02100000/ethernet at 02188000/mdio/ethernet0-phy at 0
arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /soc/aips-bus at 02100000/ethernet at 021b4000/mdio/ethernet1-phy at 0

Cc: Christoph Fritz <chf.fritz@googlemail.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx6sx-softing-vining-2000.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts b/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
index ee012bc..44bfeac 100644
--- a/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
+++ b/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
@@ -116,7 +116,7 @@
 		ethphy0: ethernet0-phy at 0 {
 			reg = <0>;
 			max-speed = <100>;
-			interrupts-parent = <&gpio2>;
+			interrupt-parent = <&gpio2>;
 			interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
 		};
 	};
@@ -139,7 +139,7 @@
 		ethphy1: ethernet1-phy at 0 {
 			reg = <0>;
 			max-speed = <100>;
-			interrupts-parent = <&gpio2>;
+			interrupt-parent = <&gpio2>;
 			interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
 		};
 	};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/4] ARM: dts: imx35-eukrea-mbimxsd35-baseboard: Fix the 'cd-gpios' property
  2017-10-16 22:34 [PATCH 1/4] ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property Fabio Estevam
  2017-10-16 22:34 ` [PATCH 2/4] ARM: dts: imx6sx-softing-vining-2000: Fix the 'interrupt-parent' property Fabio Estevam
@ 2017-10-16 22:34 ` Fabio Estevam
  2017-10-16 22:34 ` [PATCH 4/4] ARM: dts: imx50: Pass the 'dma-cells' property Fabio Estevam
  2017-10-18  2:54 ` [PATCH 1/4] ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2017-10-16 22:34 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@nxp.com>

The GPIO polarity is missing in the cd-gpios property.

Fix it, so that the following build warning is gone:

  DTC     arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb: Warning (gpios_property): cd-gpios property size (8) too small for cell size 2 in /soc/aips at 53f00000/esdhc at 53fb400

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts b/arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts
index e935713..dfc7f45 100644
--- a/arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts
+++ b/arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts
@@ -65,7 +65,7 @@
 &esdhc1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_esdhc1>;
-	cd-gpios = <&gpio3 24>;
+	cd-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 4/4] ARM: dts: imx50: Pass the 'dma-cells' property
  2017-10-16 22:34 [PATCH 1/4] ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property Fabio Estevam
  2017-10-16 22:34 ` [PATCH 2/4] ARM: dts: imx6sx-softing-vining-2000: Fix the 'interrupt-parent' property Fabio Estevam
  2017-10-16 22:34 ` [PATCH 3/4] ARM: dts: imx35-eukrea-mbimxsd35-baseboard: Fix the 'cd-gpios' property Fabio Estevam
@ 2017-10-16 22:34 ` Fabio Estevam
  2017-10-18  2:54 ` [PATCH 1/4] ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2017-10-16 22:34 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@nxp.com>

Pass the '#dma-cells' property in the sdma node, so that the following
build warning is gone:

  DTC     arch/arm/boot/dts/imx50-evk.dtb
arch/arm/boot/dts/imx50-evk.dtb: Warning (dmas_property): Missing property '#dma-cells' in node /soc/aips at 60000000/sdma at 63fb0000 or bad phandle (referred from /soc/aips at 50000000/spba at 50000000/ssi at 50014000:dmas[0])

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx50.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi
index 3747d80..30edf9a 100644
--- a/arch/arm/boot/dts/imx50.dtsi
+++ b/arch/arm/boot/dts/imx50.dtsi
@@ -443,6 +443,7 @@
 				clocks = <&clks IMX5_CLK_SDMA_GATE>,
 					 <&clks IMX5_CLK_SDMA_GATE>;
 				clock-names = "ipg", "ahb";
+				#dma-cells = <3>;
 				fsl,sdma-ram-script-name = "imx/sdma/sdma-imx50.bin";
 			};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 1/4] ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property
  2017-10-16 22:34 [PATCH 1/4] ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property Fabio Estevam
                   ` (2 preceding siblings ...)
  2017-10-16 22:34 ` [PATCH 4/4] ARM: dts: imx50: Pass the 'dma-cells' property Fabio Estevam
@ 2017-10-18  2:54 ` Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2017-10-18  2:54 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Oct 16, 2017 at 08:34:01PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> The 'interrupts' property has an extra cell by mistake.
> 
> Fix this, so that the following build warning is gone:
> 
>  DTC     arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
> arch/arm/boot/dts/imx6ul-pico-hobbit.dtb: Warning (interrupts_property): interrupts size is (12), expected multiple of 8 in /soc/aips-bus at 2000000/ethernet at 20b4000/mdio/ethernet-phy at 1
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-10-18  2:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-16 22:34 [PATCH 1/4] ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property Fabio Estevam
2017-10-16 22:34 ` [PATCH 2/4] ARM: dts: imx6sx-softing-vining-2000: Fix the 'interrupt-parent' property Fabio Estevam
2017-10-16 22:34 ` [PATCH 3/4] ARM: dts: imx35-eukrea-mbimxsd35-baseboard: Fix the 'cd-gpios' property Fabio Estevam
2017-10-16 22:34 ` [PATCH 4/4] ARM: dts: imx50: Pass the 'dma-cells' property Fabio Estevam
2017-10-18  2:54 ` [PATCH 1/4] ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).