From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iio: adc: sun4i-gpadc: use of_device_get_match_data
Date: Sat, 21 Oct 2017 18:49:00 +0100 [thread overview]
Message-ID: <20171021184900.7e3e42d0@archlinux> (raw)
In-Reply-To: <20171020053729.23248-1-clabbe.montjoie@gmail.com>
On Fri, 20 Oct 2017 07:37:29 +0200
Corentin Labbe <clabbe.montjoie@gmail.com> wrote:
> The usage of of_device_get_match_data reduce the code size a bit.
> Furthermore, it prevents an improbable dereference when
> of_match_device() return NULL.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Nice little tidy up - thanks.
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/sun4i-gpadc-iio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/sun4i-gpadc-iio.c b/drivers/iio/adc/sun4i-gpadc-iio.c
> index c4e70f1cad79..04d7147e0110 100644
> --- a/drivers/iio/adc/sun4i-gpadc-iio.c
> +++ b/drivers/iio/adc/sun4i-gpadc-iio.c
> @@ -501,17 +501,15 @@ static int sun4i_gpadc_probe_dt(struct platform_device *pdev,
> struct iio_dev *indio_dev)
> {
> struct sun4i_gpadc_iio *info = iio_priv(indio_dev);
> - const struct of_device_id *of_dev;
> struct resource *mem;
> void __iomem *base;
> int ret;
>
> - of_dev = of_match_device(sun4i_gpadc_of_id, &pdev->dev);
> - if (!of_dev)
> + info->data = of_device_get_match_data(&pdev->dev);
> + if (!info->data)
> return -ENODEV;
>
> info->no_irq = true;
> - info->data = (struct gpadc_data *)of_dev->data;
> indio_dev->num_channels = ARRAY_SIZE(sun8i_a33_gpadc_channels);
> indio_dev->channels = sun8i_a33_gpadc_channels;
>
prev parent reply other threads:[~2017-10-21 17:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 5:37 [PATCH] iio: adc: sun4i-gpadc: use of_device_get_match_data Corentin Labbe
2017-10-21 17:49 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021184900.7e3e42d0@archlinux \
--to=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).