From: krzk@kernel.org (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: exynos: add cpu perf counters to Exynos54xx boards
Date: Sat, 21 Oct 2017 22:14:01 +0200 [thread overview]
Message-ID: <20171021201401.enzhfzjkzyihtjvv@kozik-lap> (raw)
In-Reply-To: <CAM3PiRyEdXX26aBfuS=3rQK3k7ovR=HeeoF8Qcz0Dt-zdiXuww@mail.gmail.com>
On Sat, Oct 21, 2017 at 05:54:31PM +1030, Marian Mihailescu wrote:
> Hi Robin,
>
> Apologies, I did not really check which cluster is described for the
> 5410 (since 5422 boots from the A7).
>
> Should I define both pmu nodes (w/o interrupt affinity) in the
> exynos54xx,dtsi, and set the status property to "disabled"?
> And then add the interrupt affinity to the SoC variant, and enable
> them as required...
After putting it under common exynos54xx you would have to anyway
override/extend most of the nodes so I think there is no much sense for
that. Instead it should be in exynos5410.dtsi and exynos5422.dtsi.
>
> The problem that I see however is that, while 5410 is easy to deal
> with (it has the cpus defined in exynos5420.dtsi for all boards), 542x
> variants have the cpus included in the board dts. So there would be
> the same pmu nodes with interrupt affinity copied in all 542x and 5800
> boards dts (and there are several of them), instead of being included
> in exynos542x.dtsi...
You mean exynos5420-cpus.dtsi, not board DTS?
For exynos542x/5800 you could indeed add it directly to
exynos542x-cpus.dtsi, following existing pattern about cpus (with
comment).
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-10-21 20:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 12:09 [PATCH] ARM: dts: exynos: add cpu perf counters to Exynos54xx boards Marian Mihailescu
2017-10-20 12:21 ` Krzysztof Kozlowski
2017-10-20 16:15 ` Robin Murphy
2017-10-21 7:24 ` Marian Mihailescu
2017-10-21 20:14 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-20 12:49 memeka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021201401.enzhfzjkzyihtjvv@kozik-lap \
--to=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox