linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/6] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property
Date: Mon, 23 Oct 2017 08:38:10 +0800	[thread overview]
Message-ID: <20171023003808.GC8700@dragon> (raw)
In-Reply-To: <1508514507-30736-6-git-send-email-marco.franchi@nxp.com>

On Fri, Oct 20, 2017 at 01:48:27PM -0200, Marco Franchi wrote:
> The following build warning is seen with W=1:
> 
> Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property
> 
> Fix this warning by adding reg property from such node.
> 
> Signed-off-by: Marco Franchi <marco.franchi@nxp.com>

I'm not sure if you tested the change, but I'm seeing the following
warning.

Warning (reg_format): "reg" property in
/soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has invalid length
(4 bytes) (#address-cells == 2, #size-cells == 1)

Shawn

> ---
> Changes since v2:
> -change message log
> -add reg property
>  arch/arm/boot/dts/imx53-tx53.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
> index 76e7186..61ecd13 100644
> --- a/arch/arm/boot/dts/imx53-tx53.dtsi
> +++ b/arch/arm/boot/dts/imx53-tx53.dtsi
> @@ -226,6 +226,7 @@
>  	status = "okay";
>  
>  	phy0: ethernet-phy at 0 {
> +		reg = <0>;
>  		interrupts-extended = <&gpio2 4 IRQ_TYPE_EDGE_FALLING>;
>  		device_type = "ethernet-phy";
>  	};
> -- 
> 2.7.4
> 

  reply	other threads:[~2017-10-23  0:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-20 15:48 [PATCH v3 1/6] ARM: dts: imx51-apf51dev: Fix 'backlight@bl1' node with unit name and no reg property Marco Franchi
2017-10-20 15:48 ` [PATCH v3 2/6] ARM: dts: imx51-ts4800: Fix 'port@0' " Marco Franchi
2017-10-20 15:48 ` [PATCH v3 3/6] ARM: dts: imx53: Fix 'usbphy@x' " Marco Franchi
2017-10-20 15:48 ` [PATCH v3 4/6] ARM: dts: imx53-m53evk: Fix 'led_gpio@0' " Marco Franchi
2017-10-20 15:48 ` [PATCH v3 5/6] ARM: dts: imx53-qsb-common: Fix 'led_gpio7_7@0' " Marco Franchi
2017-10-20 15:48 ` [PATCH v3 6/6] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' " Marco Franchi
2017-10-23  0:38   ` Shawn Guo [this message]
2017-10-23  0:39 ` [PATCH v3 1/6] ARM: dts: imx51-apf51dev: Fix 'backlight@bl1' " Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171023003808.GC8700@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).