From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ata: fixes kernel crash while tracing ata_eh_link_autopsy event
Date: Wed, 25 Oct 2017 07:54:50 -0700 [thread overview]
Message-ID: <20171025145450.GA59538@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1508926976-11467-1-git-send-email-rsahu@apm.com>
Hello,
On Wed, Oct 25, 2017 at 03:52:56PM +0530, Rameshwar Prasad Sahu wrote:
> @@ -288,8 +289,8 @@
> ),
>
> TP_fast_assign(
> - __entry->ata_port = dev->link->ap->print_id;
> - __entry->ata_dev = dev->link->pmp + dev->devno;
> + __entry->ata_port = link->ap->print_id;
> + __entry->ata_dev = link->pmp + link->device->devno;
The above is wrong if there are multiple devices on the link. It
probably should take both link and dev and use dev iff it's not NULL.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-10-25 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 10:22 [PATCH] ata: fixes kernel crash while tracing ata_eh_link_autopsy event Rameshwar Prasad Sahu
2017-10-25 14:54 ` Tejun Heo [this message]
[not found] ` <CAFd313w9W2hHFPJ47y0jeNb1u7=0deLtwcRF=+HXGBYft-QaLw@mail.gmail.com>
2017-11-01 14:30 ` Tejun Heo
2017-11-02 9:57 ` Rameshwar Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025145450.GA59538@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).