public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dt-bindings: add binding for A64 DE2 CCU with SRAM section
Date: Fri, 27 Oct 2017 17:13:34 +0200	[thread overview]
Message-ID: <20171027151334.c3b7yqoiexgwopsf@flea> (raw)
In-Reply-To: <b8c770bdc7a0541b8d1179598d814b75@aosc.io>

On Fri, Oct 27, 2017 at 10:33:29PM +0800, icenowy at aosc.io wrote:
> ? 2017-10-16 20:09?Maxime Ripard ???
> > On Mon, Oct 16, 2017 at 05:41:10PM +0800, icenowy at aosc.io wrote:
> > > ? 2017-10-16 17:11?Maxime Ripard ???
> > > > On Sat, Oct 14, 2017 at 08:29:24PM +0800, Icenowy Zheng wrote:
> > > > > A64's Display Engine 2.0 needs a section of SRAM (SRAM C) to be
> > > > > claimed.
> > > >
> > > > Why?
> > > 
> > > Allwinner didn't document this, but if the SRAM is not claimed, the
> > > DE2 MMIO zone is totally not accessible.
> > 
> > Not accessible how? It generates an abort when you access it? It
> > returns 0?
> > 
> > > It seems that Allwinner uses the SRAM C in the DE2 internally.
> > 
> > Then shouldn't it be tied to all the DE2 devices then? So mixers
> > too. Either way, this should be mentionned in your commit logs. How
> > you're fixing things is much less interesting than why you're doing
> > them. You can tell how you're doing them from your code already.
> 
> Yes I checked and when the SRAM is not claimed any part in DE2 memory
> zone can't be accessed.

Then all the nodes that depend on it should have it, and the bindings
should be modified appropriately.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171027/59cf5cc0/attachment.sig>

      reply	other threads:[~2017-10-27 15:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-14 12:29 [PATCH 1/2] dt-bindings: add binding for A64 DE2 CCU with SRAM section Icenowy Zheng
2017-10-14 12:29 ` [PATCH 2/2] clk: sunxi-ng: add support for Allwinner A64 DE2 CCU Icenowy Zheng
2017-10-16  9:11 ` [PATCH 1/2] dt-bindings: add binding for A64 DE2 CCU with SRAM section Maxime Ripard
2017-10-16  9:41   ` icenowy at aosc.io
2017-10-16 12:09     ` Maxime Ripard
2017-10-27 14:33       ` icenowy at aosc.io
2017-10-27 15:13         ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171027151334.c3b7yqoiexgwopsf@flea \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox