[PATCH 1/2] arm64: dts: orange-pi-zero-plus2: fix sdcard detect

Jagan Teki
2017-11-21T13:41:00Z

On Wed, Nov 15, 2017 at 12:23 AM, Sergey Matyukevich <geomatsi@gmail.com> wrote:
> Hello Maxime, Jagan,
>
>> > > >> >>> > Did you try to boot from sdcard ? I am not able to boot my board from
>> > > >> >>> > sd-card without this change. As I mentioned earlier in my email
>> > > >> >>> > to buildroot mailing list, with mmc debug enabled I see that mmc
>> > > >> >>> > tries to init sd-card when I remove it from the slot.
>> > > >> >>> >
>> > > >> >>> > Maybe there is a minor differences between h/w versions or batches ?
>> > > >> >>> > What is you board version ? I tested on board v1.0.
>> > > >> >>>
>> > > >> >>> Looking at the schematics, it definitely looks like it's active low.
>> > > >> >>
>> > > >> >> Is it ok to merge it then ? Or using 'cd-inverted' property
>> > > >> >> is the preferable option ?
>> > > >> >
>> > > >> > W/o any change mainline works unstable for me, it wasn't booting
>> > > >> > at-all[1] did you find the same?
>> > > >> >
>> > > >> > Even tried with active LOW and cd-inverted.
>> > > >> >
>> > > >> > [1] https://paste.ubuntu.com/25909064/
>> > > >>
>> > > >> Look like something broken for H5 and A64 between v4.14-rc8 to latest
>> > > >
>> > > > Both 4.13.7 and 4.14-rc8 (synched today) kernels worked fine for me.
>> > > > DTS behavior is all the same:
>> > >
>> > > I've tried fresh sync [2] but still see the issue, can you check the
>> > > Image size of log(suspecting on that area)
>> >
>> > Do you plan to accept this patch as well ? Or you would prefer to wait
>> > for the confirmation from Jagan as well ?
>>
>> I'm happy with the patch, but I was under the impression that the
>> discussion had not settled yet. If it did, then yeah I'll merge it :)
>
> Both schematics and my tests on v1.0 board confirm that this fix is ok.
> However we haven't yet got the ACK from Jagan, the original submitter
> of this dts file. FWIW discussion was mostly about the problems with
> his setup and not about the fix itself.
>
> Jagan,
> did you have a chance to resolve the issues with your setup and verify
> that boot from sd-card is fixed by this patch ?

Acked-by: Jagan Teki <jagan@openedev.com>