public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: geomatsi@gmail.com (Sergey Matyukevich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: dts: orange-pi-zero-plus2: fix sdcard detect
Date: Mon, 6 Nov 2017 19:13:06 +0300	[thread overview]
Message-ID: <20171106161306.tq6yeq6bq36ridj3@speedy.hunter> (raw)
In-Reply-To: <20171106122633.5mnqfh6xhmmxr45s@flea>

Hello Maxime,

> > > > The sdcard detect pin on orange-pi-zero-plus2 is pulled up.
> > > > Fix cd-gpio description to enable sdcard detect.
> > > >
> > > > Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> > > > ---
> > > >  arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
> > > > index b6b7a561df8c..a42fd79a62a3 100644
> > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
> > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
> > > > @@ -71,7 +71,7 @@
> > > >         pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
> > > >         vmmc-supply = <&reg_vcc3v3>;
> > > >         bus-width = <4>;
> > > > -       cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
> > > > +       cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
> > > 
> > > Was able to detect and do mount with existing dts
> > 
> > Did you try to boot from sdcard ? I am not able to boot my board from
> > sd-card without this change. As I mentioned earlier in my email
> > to buildroot mailing list, with mmc debug enabled I see that mmc
> > tries to init sd-card when I remove it from the slot.
> > 
> > Maybe there is a minor differences between h/w versions or batches ?
> > What is you board version ? I tested on board v1.0.
> 
> Looking at the schematics, it definitely looks like it's active low.

Is it ok to merge it then ? Or using 'cd-inverted' property
is the preferable option ?

Regards,
Sergey

  reply	other threads:[~2017-11-06 16:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 19:58 [PATCH 0/2] arm64: dts: orange-pi-zero-plus2 mmc and wifi Sergey Matyukevich
2017-11-03 19:58 ` [PATCH 1/2] arm64: dts: orange-pi-zero-plus2: fix sdcard detect Sergey Matyukevich
2017-11-04 12:03   ` Jagan Teki
2017-11-04 15:42     ` Sergey Matyukevich
     [not found]       ` <CAMty3ZCxXUaBf3t=3d7D+RU6rp83oJw8BHADU3TYDeM4Vx_k-w@mail.gmail.com>
2017-11-04 16:22         ` Sergey Matyukevich
2017-11-06 10:28           ` Jagan Teki
2017-11-06 11:25             ` Sergey Matyukevich
2017-11-06 12:26       ` Maxime Ripard
2017-11-06 16:13         ` Sergey Matyukevich [this message]
2017-11-07  7:42           ` Jagan Teki
2017-11-07 17:17             ` Jagan Teki
2017-11-07 20:12               ` Sergey Matyukevich
2017-11-08 11:25                 ` Jagan Teki
2017-11-13 19:24                   ` Sergey Matyukevich
2017-11-14 14:39                     ` Maxime Ripard
2017-11-14 18:53                       ` Sergey Matyukevich
2017-11-21 13:41                         ` Jagan Teki
2017-12-03 20:13                           ` Sergey Matyukevich
2017-12-05  9:15   ` Maxime Ripard
2017-11-03 19:58 ` [PATCH 2/2] arm64: dts: orange-pi-zero-plus2: enable AP6212a WiFi/BT combo Sergey Matyukevich
2017-11-12 20:22   ` Sergey Matyukevich
2017-11-13  9:25   ` Maxime Ripard
2017-11-29 13:53   ` Jagan Teki
2017-11-29 14:22     ` Chen-Yu Tsai
2017-11-29 18:09       ` Jagan Teki
2017-11-29 18:21         ` Sergey Matyukevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171106161306.tq6yeq6bq36ridj3@speedy.hunter \
    --to=geomatsi@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox