From: philip@cog.systems (Philip Derrin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] STRICT_KERNEL_RWX weakened on ARM by CONFIG_ARM_LPAE=y
Date: Thu, 9 Nov 2017 11:41:42 +1100 [thread overview]
Message-ID: <20171109004144.2246-1-philip@cog.systems> (raw)
Hi,
This patch series fixes a bug which makes CONFIG_STRICT_KERNEL_RWX ineffective
when CONFIG_ARM_LPAE is enabled. Specifically, the kernel text and rodata are
mapped writeable. This has been the case since DEBUG_RODATA for ARM was first
merged in 3.19.
The cause was an incorrect conflict resolution in 1e3479225acb ("ARM: 8275/1:
mm: fix PMD_SECT_RDONLY undeclared compile error") between the commit that
implemented DEBUG_RODATA, 80d6b0c2eed2 ("ARM: mm: allow text and rodata
sections to be read-only"), and another that moved the LPAE read-only bit into
a software bit, ded947798469 ("ARM: 8109/1: mm: Modify pte_write and pmd_write
logic for LPAE").
The incorrect mappings were not apparent in the debugfs kernel_page_tables
dump because that was checking only the software RO bit, not the hardware RO
bit.
Regards,
Philip
Philip Derrin (2):
ARM: mm: make STRICT_KERNEL_RWX effective for LPAE
ARM: mm: dump: check hardware RO bit for LPAE
arch/arm/mm/dump.c | 4 ++--
arch/arm/mm/init.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
--
2.15.0
next reply other threads:[~2017-11-09 0:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 0:41 Philip Derrin [this message]
2017-11-09 0:41 ` [PATCH 1/2] ARM: mm: make STRICT_KERNEL_RWX effective for LPAE Philip Derrin
2017-11-09 0:41 ` [PATCH 2/2] ARM: mm: dump: check hardware RO bit " Philip Derrin
2017-11-09 1:23 ` [PATCH 0/2] STRICT_KERNEL_RWX weakened on ARM by CONFIG_ARM_LPAE=y Kees Cook
2017-11-09 9:37 ` Russell King - ARM Linux
2017-11-09 9:49 ` Baruch Siach
2017-11-09 23:13 ` Russell King - ARM Linux
2017-11-14 2:48 ` Philip Derrin
2017-11-20 18:45 ` Florian Fainelli
2017-11-20 19:01 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109004144.2246-1-philip@cog.systems \
--to=philip@cog.systems \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).