From: jlu@pengutronix.de (Jan Luebbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/7] ARM: l2x0: add marvell,ecc-enable property for aurora
Date: Fri, 10 Nov 2017 10:03:06 +0100 [thread overview]
Message-ID: <20171110090308.21562-6-jlu@pengutronix.de> (raw)
In-Reply-To: <20171110090308.21562-1-jlu@pengutronix.de>
From: Chris Packham <chris.packham@alliedtelesis.co.nz>
The aurora cache on the Marvell Armada-XP SoC supports ECC protection
for the L2 data arrays. Add a "marvell,ecc-enable" device tree property
which can be used to enable this.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
[jlu at pengutronix.de: use aurora specific define AURORA_ACR_ECC_EN]
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
---
Documentation/devicetree/bindings/arm/l2c2x0.txt | 2 ++
arch/arm/mm/cache-l2x0.c | 7 +++++++
2 files changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/l2c2x0.txt b/Documentation/devicetree/bindings/arm/l2c2x0.txt
index fbe6cb21f4cf..15a84f0ba9f1 100644
--- a/Documentation/devicetree/bindings/arm/l2c2x0.txt
+++ b/Documentation/devicetree/bindings/arm/l2c2x0.txt
@@ -76,6 +76,8 @@ Optional properties:
specified to indicate that such transforms are precluded.
- arm,parity-enable : enable parity checking on the L2 cache (L220 or PL310).
- arm,parity-disable : disable parity checking on the L2 cache (L220 or PL310).
+- marvell,ecc-enable : enable ECC protection on the L2 cache
+- marvell,ecc-disable : disable ECC protection on the L2 cache
- arm,outer-sync-disable : disable the outer sync operation on the L2 cache.
Some core tiles, especially ARM PB11MPCore have a faulty L220 cache that
will randomly hang unless outer sync operations are disabled.
diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index b70bee74750d..644f786e4fa9 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -1505,6 +1505,13 @@ static void __init aurora_of_parse(const struct device_node *np,
mask |= AURORA_ACR_FORCE_WRITE_POLICY_MASK;
}
+ if (of_property_read_bool(np, "marvell,ecc-enable")) {
+ mask |= AURORA_ACR_ECC_EN;
+ val |= AURORA_ACR_ECC_EN;
+ } else if (of_property_read_bool(np, "marvell,ecc-disable")) {
+ mask |= AURORA_ACR_ECC_EN;
+ }
+
if (of_property_read_bool(np, "arm,parity-enable")) {
mask |= AURORA_ACR_PARITY_EN;
val |= AURORA_ACR_PARITY_EN;
--
2.11.0
next prev parent reply other threads:[~2017-11-10 9:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 9:03 [PATCH v3 0/7] EDAC drivers for Armada XP L2 and DDR Jan Luebbe
2017-11-10 9:03 ` [PATCH v3 1/7] ARM: l2c: move cache-aurora-l2.h to asm/hardware Jan Luebbe
2017-11-10 9:03 ` [PATCH v3 2/7] ARM: aurora-l2: add prefix to MAX_RANGE_SIZE Jan Luebbe
2017-11-10 9:03 ` [PATCH v3 3/7] ARM: aurora-l2: add defines for parity and ECC registers Jan Luebbe
2017-11-10 9:03 ` [PATCH v3 4/7] ARM: l2x0: support parity-enable/disable on aurora Jan Luebbe
2017-11-10 9:03 ` Jan Luebbe [this message]
2017-11-10 9:03 ` [PATCH v3 6/7] EDAC: Add missing debugfs_create_x32 wrapper Jan Luebbe
2017-11-16 19:32 ` Borislav Petkov
2017-11-10 9:03 ` [PATCH v3 7/7] EDAC: Add driver for the Marvell Armada XP SDRAM and L2 cache ECC Jan Luebbe
2017-11-12 20:15 ` Chris Packham
2017-11-16 19:31 ` Borislav Petkov
2017-11-16 21:05 ` Andrew Lunn
2018-01-10 21:54 ` Chris Packham
2018-01-11 19:28 ` Borislav Petkov
2018-01-10 23:05 ` Chris Packham
2018-01-11 19:31 ` Borislav Petkov
2018-01-08 22:00 ` Chris Packham
2018-01-09 9:18 ` Jan Lübbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110090308.21562-6-jlu@pengutronix.de \
--to=jlu@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).