From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap3-n900: enable autofocus
Date: Sun, 12 Nov 2017 15:29:18 +0100 [thread overview]
Message-ID: <20171112142918.rqxd2uk7ljyhpctt@earth> (raw)
In-Reply-To: <20171112112528.GA21009@amd>
Hi,
On Sun, Nov 12, 2017 at 12:25:29PM +0100, Pavel Machek wrote:
>
> Connect auto-focus coil to the camera sensor, so that it can be used
> by camera applications.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
I think you should replace auto-focus with lens-focus. This is not
automatic. Otherwise:
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
-- Sebastian
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index 669c51c..59cc743 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -778,6 +778,8 @@
>
> reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
>
> + lens-focus = <&ad5820>;
> +
> port {
> csi_cam1: endpoint {
> bus-type = <3>; /* CCP2 */
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171112/8566b3fa/attachment.sig>
next prev parent reply other threads:[~2017-11-12 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 11:25 [PATCH] omap3-n900: enable autofocus Pavel Machek
2017-11-12 12:07 ` Pali Rohár
2017-11-12 14:29 ` Sebastian Reichel [this message]
2017-11-13 10:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171112142918.rqxd2uk7ljyhpctt@earth \
--to=sre@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox